Skip to contentSkip to conversation

omap: Fix compile for omap1_bl.c

PATCH New Tony Lindgren 1 participant 1 message Jan 6, 2010

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 omap: Fix compile for omap1_bl.c

Hi,

I'd like to push the following compile fix via the omap-fixes queue. Emese & Richard, care to ack?

Regards,

Tony

Quoted 1 line

From 72318a4604b7fa40a1e65d3e18f639ba0134d789 Mon Sep 17 00:00:00 2001

From: Tony Lindgren <[email protected]>
Date: Wed, 6 Jan 2010 10:31:06 -0800
Subject: [PATCH] omap: Fix compile for omap1_bl.c

Commit 9905a43b made struct backlight_ops const. Omap was setting check_fb dynamically, which caused the following compile error:

drivers/video/backlight/omap1_bl.c: In function 'omapbl_probe':
drivers/video/backlight/omap1_bl.c:142: error: assignment of read-only variable 'omapbl_ops'

Turns out pdata->check_fb is not being used, so just remove it to fix the compile.

Cc Emese Revfy <[email protected]>
Cc Richard Purdie <[email protected]>
arch/arm/plat-omap/include/plat/board.h +0 -1
index 376ce18..5cd6220 100644
@@ -99,7 +99,6 @@ struct fb_info;
 struct omap_backlight_config {
 	int default_intensity;
 	int (*set_power)(struct device *dev, int state);
-	int (*check_fb)(struct fb_info *fb);
 };
 
 struct omap_fbmem_config {
drivers/video/backlight/omap1_bl.c +0 -2
index 409ca96..a3a7f89 100644
@@ -139,8 +139,6 @@ static int omapbl_probe(struct platform_device *pdev)
 	if (!pdata)
 		return -ENXIO;
 
-	omapbl_ops.check_fb = pdata->check_fb;
-
 	bl = kzalloc(sizeof(struct omap_backlight), GFP_KERNEL);
 	if (unlikely(!bl))
 		return -ENOMEM;