Skip to contentSkip to conversation

nouveau: disable flush_notify on channel_free

PATCH In review Marcin Slusarz 2 participants 2 messages Jan 12, 2010 – Jan 14, 2010 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nouveau: disable flush_notify on channel_free

From: Marcin Slusarz <[email protected]>
Subject: [libdrm PATCH] nouveau: disable flush_notify on channel_free

We don't want do call flush_notify when we will FIRE the RING a couple of lines later, because grobj bound to this channel might be already freed.

---
 nouveau/nouveau_channel.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
nouveau/nouveau_channel.c +1 -0
index 14cf4c6..01d6681 100644
@@ -107,6 +107,7 @@ nouveau_channel_free(struct nouveau_channel **chan)
 	if (!chan || !*chan)
 		return;
 	nvchan = nouveau_channel(*chan);
+	(*chan)->flush_notify = NULL;
 	*chan = NULL;
 	nvdev = nouveau_device(nvchan->base.device);
 
Signature · 1 line
1.6.6.rc3
#2 lore raw
In reply to a message not in the archive

I'll push this one tomorrow if there are no complaints.

Quoted 30 lines · Marcin Slusarz

From: Marcin Slusarz <[email protected]>
Subject: [libdrm PATCH] nouveau: disable flush_notify on channel_free

We don't want do call flush_notify when we will FIRE the RING a couple of lines later, because grobj bound to this channel might be already freed.
---
 nouveau/nouveau_channel.c |    1 +

 1 files changed, 1 insertions(+), 0 deletions(-)
nouveau/nouveau_channel.c +1 -1
index 14cf4c6..01d6681 100644
@@ -107,6 +107,7 @@ nouveau_channel_free(struct nouveau_channel **chan)
        if (!chan || !*chan)
                return;
        nvchan = nouveau_channel(*chan);
+       (*chan)->flush_notify = NULL;
        *chan = NULL;
        nvdev = nouveau_device(nvchan->base.device);
 
--

1.6.6.rc3

_______________________________________________
Nouveau mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau