Skip to contentSkip to conversation

PATCH Jeff Mahoney 2 participants 2 messages Jan 13, 2010 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

Subject: [patch 1/6] smsc47m1: Fix section mismatch
References: <[email protected]>
Content-Disposition: inline; filename=patches.rpmify/smsc47m1-fix-section-mismatch

smsc47m1_restore is called from sm_smsc47m1_exit, which is an __exit function, so it can't be __init.

---
 drivers/hwmon/smsc47m1.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/smsc47m1.c +1 -1
@@ -488,7 +488,7 @@ static int __init smsc47m1_find(unsigned
 }
 
 /* Restore device to its initial state */
-static void __init smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
+static void smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
 {
 	if ((sio_data->activate & 0x01) == 0) {
 		superio_enter();
#1 lore raw

Re: [PATCH] hwmon: (smsc47m1) Fix section mismatch

Hi Jeff,

Quoted 16 lines · Jeff Mahoney

Subject: [patch 1/6] smsc47m1: Fix section mismatch
References: <[email protected]>
Content-Disposition: inline; filename=patches.rpmify/smsc47m1-fix-section-mismatch

smsc47m1_restore is called from sm_smsc47m1_exit, which is an __exit function, so it can't be __init.

---
 drivers/hwmon/smsc47m1.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/hwmon/smsc47m1.c static int __init smsc47m1_find(unsigned · line 494

Quoted 8 lines
drivers/hwmon/smsc47m1.c +1 -1
@@ -488,7 +488,7 @@ static int __init smsc47m1_find(unsigned
 }
 
 /* Restore device to its initial state */
-static void __init smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
+static void smsc47m1_restore(const struct smsc47m1_sio_data *sio_data)
 {
 	if ((sio_data->activate & 0x01) == 0) {
 		superio_enter();

Good catch, thanks for reporting. I do not get any warning about this one, even though I build the driver as a module and with hotplug support enabled. I don't get it.

Anyway, patch applied, thanks.

Signature · 1 line
Jean Delvare