PVSCSI: fix signedness warning with newer compilers
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 6 lines · Dmitry Torokhov
pvscsi_setup_msix()expects 'irq' argument to be an int but is being passed unsigned int. Unsigned int is more proper type for IRQ number so let's use it. This shuts off a compile warning with recent compilers.Signed-off-by Dmitry Torokhov <[email protected]>
LGTM.
Thanks.
Quoted 23 lines
--- drivers/scsi/vmw_pvscsi.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)drivers/scsi/vmw_pvscsi.c +2
-1@@ -1069,7 +1069,8 @@ static void pvscsi_free_sgls(const struct pvscsi_adapter *adapter)free_pages ((unsigned long )ctx->sgl,get_order (SGL_SIZE )); } -static int pvscsi_setup_msix (const struct pvscsi_adapter *adapter,int *irq) +static int pvscsi_setup_msix (const struct pvscsi_adapter *adapter, +unsigned int *irq) {struct msix_entry entry = {0 ,PVSCSI_VECTOR_COMPLETION };int ret;_______________________________________________
Pv-drivers mailing list
[email protected]
http://mailman2.vmware.com/mailman/listinfo/pv-drivers
Quoted 11 lines · Alok Kataria
Quoted 6 lines · Dmitry Torokhov
pvscsi_setup_msix()expects 'irq' argument to be an int but is being passed unsigned int. Unsigned int is more proper type for IRQ number so let's use it. This shuts off a compile warning with recent compilers.Signed-off-by Dmitry Torokhov <[email protected]>LGTM.
Signed-off-by Alok N Kataria <[email protected]>
That would be acked-by unless you want to resend the patch to me? I don't have an unmangled copy of it, so someone needs to send it to the scsi list.
Thanks,
James
Quoted 9 lines · James Bottomley
Quoted 8 lines · Alok Kataria
Quoted 6 lines · Dmitry Torokhov
pvscsi_setup_msix()expects 'irq' argument to be an int but is being passed unsigned int. Unsigned int is more proper type for IRQ number so let's use it. This shuts off a compile warning with recent compilers.Signed-off-by Dmitry Torokhov <[email protected]>
Quoted 8 lines
Quoted 3 lines
LGTM.
Signed-off-by Alok N Kataria <[email protected]>That would be acked-by unless you want to resend the patch to me? I don't have an unmangled copy of it, so someone needs to send it to the scsi list.
Acked-by is fine with me too. If its an hassle to pick these lines after the patch is sent, I am totally fine if you pick the patch without my Acked-by or SOB line, just wanted to acknowledge that the change is fine by me.
Thanks,
Alok
Quoted 5 lines
Thanks,
James
Quoted 14 lines · Alok Kataria
Quoted 13 lines · James Bottomley
Quoted 11 lines · Alok Kataria
Quoted 6 lines · Dmitry Torokhov
pvscsi_setup_msix()expects 'irq' argument to be an int but is being passed unsigned int. Unsigned int is more proper type for IRQ number so let's use it. This shuts off a compile warning with recent compilers.Signed-off-by Dmitry Torokhov <[email protected]>LGTM.
Signed-off-by Alok N Kataria <[email protected]>
Quoted 9 lines
Quoted 3 lines
That would be acked-by unless you want to resend the patch to me? I don't have an unmangled copy of it, so someone needs to send it to the scsi list.
Acked-by is fine with me too. If its an hassle to pick these lines after the patch is sent, I am totally fine if you pick the patch without my Acked-by or SOB line, just wanted to acknowledge that the change is fine by me.
Hm, I wonder why the original did not make through to linux-scsi/James. I will resend from my other address then.
Signature · 1 line
Dmitry
Quoted 19 lines · Dmitry Torokhov
Quoted 18 lines · Alok Kataria
Quoted 16 lines · James Bottomley
Quoted 11 lines · Alok Kataria
Quoted 6 lines · Dmitry Torokhov
pvscsi_setup_msix()expects 'irq' argument to be an int but is being passed unsigned int. Unsigned int is more proper type for IRQ number so let's use it. This shuts off a compile warning with recent compilers.Signed-off-by Dmitry Torokhov <[email protected]>LGTM.
Signed-off-by Alok N Kataria <[email protected]>That would be acked-by unless you want to resend the patch to me? I don't have an unmangled copy of it, so someone needs to send it to the scsi list.
Quoted 8 lines
Quoted 5 lines
Acked-by is fine with me too. If its an hassle to pick these lines after the patch is sent, I am totally fine if you pick the patch without my Acked-by or SOB line, just wanted to acknowledge that the change is fine by me.
Hm, I wonder why the original did not make through to linux-scsi/James. I will resend from my other address then.
Well, sometimes it's because someone is using a mail tool that breaks threading ... but I did a subject search, it definitely isn't in my folder. Vger has a fairly esoteric spam reduction mechanism based on regexps ... perhaps you fell foul of that?
James
Quoted 25 lines · James Bottomley
Quoted 24 lines · Dmitry Torokhov
Quoted 22 lines · Alok Kataria
Quoted 9 lines · James Bottomley
Quoted 8 lines · Alok Kataria
Quoted 6 lines · Dmitry Torokhov
pvscsi_setup_msix()expects 'irq' argument to be an int but is being passed unsigned int. Unsigned int is more proper type for IRQ number so let's use it. This shuts off a compile warning with recent compilers.Signed-off-by Dmitry Torokhov <[email protected]>Quoted 7 lines
Quoted 3 lines
LGTM.
Signed-off-by Alok N Kataria <[email protected]>That would be acked-by unless you want to resend the patch to me? I don't have an unmangled copy of it, so someone needs to send it to the scsi list.
Acked-by is fine with me too. If its an hassle to pick these lines after the patch is sent, I am totally fine if you pick the patch without my Acked-by or SOB line, just wanted to acknowledge that the change is fine by me.
Quoted 7 lines
Quoted 2 lines
Hm, I wonder why the original did not make through to linux-scsi/James. I will resend from my other address then.
Well, sometimes it's because someone is using a mail tool that breaks threading ... but I did a subject search, it definitely isn't in my folder. Vger has a fairly esoteric spam reduction mechanism based on regexps ... perhaps you fell foul of that?
Mutt usually does not fail me when sending patches. Let's see if my other account works better.
Signature · 1 line
Dmitry
Quoted 14 lines · Alok Kataria
Quoted 13 lines · James Bottomley
Quoted 11 lines · Alok Kataria
Quoted 6 lines · Dmitry Torokhov
pvscsi_setup_msix()expects 'irq' argument to be an int but is being passed unsigned int. Unsigned int is more proper type for IRQ number so let's use it. This shuts off a compile warning with recent compilers.Signed-off-by Dmitry Torokhov <[email protected]>LGTM.
Signed-off-by Alok N Kataria <[email protected]>
Quoted 8 lines
Quoted 4 lines
That would be acked-by unless you want to resend the patch to me? I don't have an unmangled copy of it, so someone needs to send it to the scsi list.
Acked-by is fine with me too. If its an hassle to pick these lines after the patch is sent, I am totally fine if you pick the patch without my Acked-by or SOB line, just wanted to acknowledge that the change is fine by me.
The difference is Acked-by means you looked at the patch and said it was OK. This is fairly essential if you want the change to go into the SCSI tree because otherwise it goes in my pile to look at ordered by importance (and changes like this tend to land close to the bottom).
If you want to send it to me yourself, you resend it with a signed-off-by tag (this tracks whose hands the change passed through).
James