proc: warn on non-existing proc entries

PATCH New Alexey Dobriyan 1 participant 1 message Jan 20, 2010

Subsystems (2)

VFS Proc filesystem

lore

Share & tools

lore

Alexey Dobriyan

author

2010-01-20 20:41 UTC #0 lore raw

PATCH 2/2 proc: warn on non-existing proc entries

* warn if creation goes on to non-existent directory
* warn if removal goes on from non-existing directory
* warn if non-existing proc entry is removed

Signed-off-by Alexey Dobriyan <[email protected]>

---

 fs/proc/generic.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

fs/proc/generic.c +6 -2

@@ -312,8 +312,10 @@ static int __xlate_proc_name(const char *name, struct proc_dir_entry **ret,
 			if (proc_match(len, cp, de))
 				break;
 		}
-		if (!de)
+		if (!de) {
+			WARN(1, "name '%s'\n", name);
 			return -ENOENT;
+		}
 		cp += len + 1;
 	}
 	*residual = cp;

@@ -814,8 +816,10 @@ void remove_proc_entry(const char *name, struct proc_dir_entry *parent)
 		}
 	}
 	spin_unlock(&proc_subdir_lock);
-	if (!de)
+	if (!de) {
+		WARN(1, "name '%s'\n", name);
 		return;
+	}
 
 	spin_lock(&de->pde_unload_lock);
 	/*