Skip to contentSkip to conversation

hpsa: fix scsi status reporting yet again.

PATCH In review [email protected] 1 participant 1 message Feb 2, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 hpsa: fix scsi status reporting yet again.

From: Stephen M. Cameron <[email protected]>

Fix scsi status reporting yet again, reverting an earlier attempt. The status byte does not need to be shifted << 1. Code in other drivers that does "scp->result |= CHECK_CONDITION << 1;" works because CHECK_CONDITION macro is pre-shifted right 1 bit.

---

 drivers/scsi/hpsa.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/hpsa.c renamed from drivers/scsi/hpsa.c~hpsa-fix-scsi-status-reporting-yet-again +1 -1
diff -puN drivers/scsi/hpsa.c~hpsa-fix-scsi-status-reporting-yet-again drivers/scsi/hpsa.c
@@ -930,7 +930,7 @@ static void complete_scsi_command(struct
 
 	cmd->result = (DID_OK << 16); 		/* host byte */
 	cmd->result |= (COMMAND_COMPLETE << 8);	/* msg byte */
-	cmd->result |= (ei->ScsiStatus << 1);
+	cmd->result |= ei->ScsiStatus;
 
 	/* copy the sense data whether we need to or not. */
 	memcpy(cmd->sense_buffer, ei->SenseInfo,

_