xfs: optimize log flushing in xfs_fsync
PATCH 1/1 xfs: optimize log flushing in xfs_fsync
If we have a pinned inode it must have a log item attached to it. Usually that log item will have ili_last_lsn already set, in which case we only need to flush the log up to that LSN instead of doing a full log force. This gives speedups of about 5% in some fsync heavy workloads.
fs/xfs/xfs_vnodeops.c +8 -2
@@ -626,8 +626,14 @@ xfs_fsync(* force the log. */ if (xfs_ipincount (ip)) { - error =_xfs_log_force (ip->i_mount,XFS_LOG_SYNC , - &log_flushed); +if (ip->i_itemp->ili_last_lsn) { + error =_xfs_log_force_lsn (ip->i_mount, + ip->i_itemp->ili_last_lsn, +XFS_LOG_SYNC , &log_flushed); + }else { + error =_xfs_log_force (ip->i_mount, +XFS_LOG_SYNC , &log_flushed); + } } }else {/*
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 5 lines · Christoph Hellwig
If we have a pinned inode it must have a log item attached to it. Usually that log item will have
ili_last_lsnalready set, in which case we only need to flush the log up to that LSN instead of doing a full log force. This gives speedups of about 5% in some fsync heavy workloads.
This looks good. I was going to suggest:
ASSERT(ip->i_itemp != NULL);
before it's dereferenced, but a pinned inode had better have an item pointer...
Quoted 24 lines
Signed-off-by Christoph Hellwig <[email protected]>Index:
xfs/fs/xfs/xfs_vnodeops.c
===================================================================fs/xfs/xfs_vnodeops.c +8
-2@@ -626,8 +626,14 @@ xfs_fsync(* force the log. */ if (xfs_ipincount (ip)) { - error =_xfs_log_force (ip->i_mount,XFS_LOG_SYNC , - &log_flushed); +if (ip->i_itemp->ili_last_lsn) { + error =_xfs_log_force_lsn (ip->i_mount, + ip->i_itemp->ili_last_lsn, +XFS_LOG_SYNC , &log_flushed); + }else { + error =_xfs_log_force (ip->i_mount, +XFS_LOG_SYNC , &log_flushed); + } } }else {/*
Quoted 4 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs