Skip to contentSkip to conversation

Inconsistency in ioread functions, const pointer or not

DISCUSSION Roman Fietze 1 participant 1 message Feb 5, 2010

lore
Share & tools
lore
#0 lore raw

Hello,

Sorry if this subject was discussed before, but I could not find anything except

http://lkml.indiana.edu/hypermail/linux/kernel/0702.0/0328.html

The old ioreadx routines have been macros using the appropriate readx functions or macros, those in turn used some raw read functions, which finally used a memory pointer like this one:

static inline u8 __raw_readb(const volatile void __iomem *addr)

The iomap ioreadx functions have signatures like

extern unsigned int ioread8(void __iomem *)

I can understand the discussion about the volatile qualifier, but how about the const?

Any pointer to discussions about removing const would be helpful.

If there are none of them, does anybody know the reason for removing the const?

Additional question would be about the return types and target types for the pointer, why they are int instead of e.g. u8 or void * instead of u8 *, but probably this has to be another thread or was discussed somewhere else.

Roman

Signature · 3 lines
Roman Fietze                Telemotive AG Büro Mühlhausen
Breitwiesen                              73347 Mühlhausen
Tel.: +49(0)7335/18493-45        http://www.telemotive.de