Skip to contentSkip to conversation

EP93xx: Fix system controller register definitions

PATCH In review Matthias Kaehlcke 2 participants 2 messages Feb 6, 2010 – Feb 8, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EP93xx: Fix system controller register definitions

EP93xx: The system controller register definition doesn't take into account a 4 byte gap between ChipId and SysCfg, in consequence all accesses to syscon registers ahead of ChipId fail. Fix this by inserting a filler field

---
 arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h +2 -1
index 50bb0eb..544f7f9 100644
@@ -562,8 +562,9 @@ struct syscon_regs {
 	uint32_t i2sclkdiv;
 	uint32_t keytchclkdiv;
 	uint32_t chipid;
+	uint32_t reserved4;
 	uint32_t syscfg;
-	uint32_t reserved4[8];
+	uint32_t reserved5[8];
 	uint32_t sysswlock;
 };
 #else
Signature · 7 lines
1.6.5


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

Hi Matthias,

Quoted 5 lines · Matthias Kaehlcke

EP93xx: The system controller register definition doesn't take into account a 4 byte gap between ChipId and SysCfg, in consequence all accesses to syscon registers ahead of ChipId fail. Fix this by inserting a filler field

Your patches seem ok, I applied all three.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox