Skip to contentSkip to conversation

mac80211: give warning if building w/out rate ctrl algorithm

PATCH In review Andres Salomon 6 participants 10 messages Feb 8, 2010 – Feb 16, 2010 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 mac80211: give warning if building w/out rate ctrl algorithm

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack w/ no rate control algorithm. When RC_MINISTREL and RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses as the fallback algorithm) will be "". That'll cause the rate_control_alloc to fail, which will in turn cause ieee80211_register_hw to fail. IOW, no driver will load.

This will tell kconfig to provide a warning if no rate control algorithms have been selected. That'll at least warn the user that they're about to build a broken wireless stack.

---
 net/mac80211/Kconfig |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
net/mac80211/Kconfig +9 -0
index a10d508..1f0ebab 100644
@@ -15,8 +15,12 @@ comment "CFG80211 needs to be enabled for MAC80211"
 
 if MAC80211 != n
 
+config MAC80211_HAS_RC
+	def_bool n
+
 config MAC80211_RC_PID
 	bool "PID controller based rate control algorithm" if EMBEDDED
+	select MAC80211_HAS_RC
 	---help---
 	  This option enables a TX rate control algorithm for
 	  mac80211 that uses a PID controller to select the TX
@@ -24,12 +28,14 @@ config MAC80211_RC_PID
 
 config MAC80211_RC_MINSTREL
 	bool "Minstrel" if EMBEDDED
+	select MAC80211_HAS_RC
 	default y
 	---help---
 	  This option enables the 'minstrel' TX rate control algorithm
 
 choice
 	prompt "Default rate control algorithm"
+	depends on MAC80211_HAS_RC
 	default MAC80211_RC_DEFAULT_MINSTREL
 	---help---
 	  This option selects the default rate control algorithm
@@ -62,6 +68,9 @@ config MAC80211_RC_DEFAULT
 
 endif
 
+comment "mac80211 will not work properly w/out rate control algorithm"
+	depends on MAC80211_HAS_RC=n
+
 config MAC80211_MESH
 	bool "Enable mac80211 mesh networking (pre-802.11s) support"
 	depends on MAC80211 && EXPERIMENTAL
Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 6 lines · Andres Salomon

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack w/ no rate control algorithm. When RC_MINISTREL and RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses as the fallback algorithm) will be "". That'll cause the rate_control_alloc to fail, which will in turn cause ieee80211_register_hw to fail. IOW, no driver will load.

There are devices that don't need rate control algorithm, for example wl1271 (see IEEE80211_HW_HAS_RATE_CONTROL). A better solution is instead to fix rate_control_alloc() to handle this, or something similar.

Signature · 1 line
Kalle Valo
#2 lore raw
Quoted 14 lines · Kalle Valo
Quoted 6 lines · Andres Salomon

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack w/ no rate control algorithm. When RC_MINISTREL and RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses as the fallback algorithm) will be "". That'll cause the rate_control_alloc to fail, which will in turn cause ieee80211_register_hw to fail. IOW, no driver will load.

There are devices that don't need rate control algorithm, for example wl1271 (see IEEE80211_HW_HAS_RATE_CONTROL). A better solution is instead to fix rate_control_alloc() to handle this, or something similar.

Quoted 7 lines

--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

There is also iwlwifi (and ath9k) which use their own RC algorithms. AFAIK they need no external RC algo either.

Signature · 1 line
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
maintainer
#3 lore raw
In reply to Andres Salomon

net/mac80211/Kconfig config MAC80211_RC_DEFAULT · line 72

Quoted 13 lines · Andres Salomon

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack w/ no rate control algorithm. When RC_MINISTREL and RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses as the fallback algorithm) will be "". That'll cause the rate_control_alloc to fail, which will in turn cause ieee80211_register_hw to fail. IOW, no driver will load.

This will tell kconfig to provide a warning if no rate control algorithms have been selected. That'll at least warn the user that they're about to build a broken wireless stack.

net/mac80211/Kconfig +2 -0
+comment "mac80211 will not work properly w/out rate control algorithm"
+	depends on MAC80211_HAS_RC=n

Except that isn't true for hardware that doesn't require an algorithm, or drivers that provide it themselves, like iwlagn or ath9k. I would prefer it to be worded accordingly.

johannes

#4 lore raw
Quoted 13 lines · On Mon, 08 Feb 2010 10:06:33 +0100 Johannes Berg <[email protected]>…
Quoted 10 lines · Andres Salomon

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack w/ no rate control algorithm. When RC_MINISTREL and RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses as the fallback algorithm) will be "". That'll cause the rate_control_alloc to fail, which will in turn cause ieee80211_register_hw to fail. IOW, no driver will load.

This will tell kconfig to provide a warning if no rate control algorithms have been selected. That'll at least warn the user that they're about to build a broken wireless stack.

Quoted 8 lines

net/mac80211/Kconfig config MAC80211_RC_DEFAULT · line 72

Quoted 3 lines

+comment "mac80211 will not work properly w/out rate control algorithm"

net/mac80211/Kconfig +1 -0
+	depends on MAC80211_HAS_RC=n

Except that isn't true for hardware that doesn't require an algorithm, or drivers that provide it themselves, like iwlagn or ath9k. I would prefer it to be worded accordingly.

Noted. I was wondering if there were any.

How about having drivers that need them depend upon MAC80211_HAS_RC or some such, and having the text say something like "most drivers require rate control"?

#6 lore raw
In reply to Andres Salomon
Quoted 10 lines · Andres Salomon

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack w/ no rate control algorithm.  When RC_MINISTREL and RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses as the fallback algorithm) will be "".  That'll cause the rate_control_alloc to fail, which will in turn cause ieee80211_register_hw to fail.  IOW, no driver will load.

This will tell kconfig to provide a warning if no rate control algorithms have been selected.  That'll at least warn the user that they're about to build a broken wireless stack.

Please Cc: [email protected] here as well, I think we've had this for a while.

Quoted 1 line

Luis

maintainer
#5 lore raw
In reply to Andres Salomon
Quoted 9 lines · Andres Salomon
Quoted 8 lines

net/mac80211/Kconfig config MAC80211_RC_DEFAULT · line 72

Quoted 3 lines

+comment "mac80211 will not work properly w/out rate control algorithm"

net/mac80211/Kconfig +1 -0
+	depends on MAC80211_HAS_RC=n

Except that isn't true for hardware that doesn't require an algorithm, or drivers that provide it themselves, like iwlagn or ath9k. I would prefer it to be worded accordingly.

Quoted 5 lines

Noted. I was wondering if there were any.

How about having drivers that need them depend upon MAC80211_HAS_RC or some such, and having the text say something like "most drivers require rate control"?

I guess that might make sense in that if you have any driver that needs it, it'd remind you to select one. I'd be happy with that if you want to do it, but that means touching all the driver Kconfig. Alternatively, I'd just reword the warning to include that possibility.

johannes

#7 lore raw
In reply to Luis R. Rodriguez
Quoted 15 lines · On Mon, 8 Feb 2010 10:32:50 -0800 "Luis R. Rodriguez" <[email protected]> wrote:
Quoted 11 lines · Andres Salomon

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack w/ no rate control algorithm.  When RC_MINISTREL and RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses as the fallback algorithm) will be "".  That'll cause the rate_control_alloc to fail, which will in turn cause ieee80211_register_hw to fail.  IOW, no driver will load.

This will tell kconfig to provide a warning if no rate control algorithms have been selected.  That'll at least warn the user that they're about to build a broken wireless stack.

Quoted 6 lines

Please Cc: [email protected] here as well, I think we've had this for a while.

Quoted 1 line

Luis

Here's an updated patch. I ended up just changing the wording.

Subject: [PATCH] mac80211: give warning if building w/out rate ctrl algorithm

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack and drivers w/ no rate control algorithm. For drivers like RTL8187 that don't supply their own RC algorithms, this will cause ieee80211_register_hw to fail (making the driver unusable).

This will tell kconfig to provide a warning if no rate control algorithms have been selected. That'll at least warn the user; users that know that their drivers supply a rate control algorithm can safely ignore the warning, and those who don't know (or who expect to be using multiple drivers) can select a default RC algorithm.

---
 net/mac80211/Kconfig |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
net/mac80211/Kconfig +9 -0
index a10d508..2a51b0b 100644
@@ -15,8 +15,12 @@ comment "CFG80211 needs to be enabled for MAC80211"
 
 if MAC80211 != n
 
+config MAC80211_HAS_RC
+	def_bool n
+
 config MAC80211_RC_PID
 	bool "PID controller based rate control algorithm" if EMBEDDED
+	select MAC80211_HAS_RC
 	---help---
 	  This option enables a TX rate control algorithm for
 	  mac80211 that uses a PID controller to select the TX
@@ -24,12 +28,14 @@ config MAC80211_RC_PID
 
 config MAC80211_RC_MINSTREL
 	bool "Minstrel" if EMBEDDED
+	select MAC80211_HAS_RC
 	default y
 	---help---
 	  This option enables the 'minstrel' TX rate control algorithm
 
 choice
 	prompt "Default rate control algorithm"
+	depends on MAC80211_HAS_RC
 	default MAC80211_RC_DEFAULT_MINSTREL
 	---help---
 	  This option selects the default rate control algorithm
@@ -62,6 +68,9 @@ config MAC80211_RC_DEFAULT
 
 endif
 
+comment "some wireless drivers require a rate control algorithm"
+	depends on MAC80211_HAS_RC=n
+
 config MAC80211_MESH
 	bool "Enable mac80211 mesh networking (pre-802.11s) support"
 	depends on MAC80211 && EXPERIMENTAL
Signature · 1 line
1.5.6.5
#8 lore raw
Quoted 37 lines · Andres Salomon
Quoted 15 lines · On Mon, 8 Feb 2010 10:32:50 -0800 "Luis R. Rodriguez" <[email protected]> wrote:
Quoted 11 lines · Andres Salomon

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack w/ no rate control algorithm.  When RC_MINISTREL and RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses as the fallback algorithm) will be "".  That'll cause the rate_control_alloc to fail, which will in turn cause ieee80211_register_hw to fail.  IOW, no driver will load.

This will tell kconfig to provide a warning if no rate control algorithms have been selected.  That'll at least warn the user that they're about to build a broken wireless stack.

Quoted 6 lines

Please Cc: [email protected] here as well, I think we've had this for a while.

Quoted 1 line

  Luis

Here's an updated patch.  I ended up just changing the wording.

Subject: [PATCH] mac80211: give warning if building w/out rate ctrl algorithm

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack and drivers w/ no rate control algorithm.  For drivers like RTL8187 that don't supply their own RC algorithms, this will cause ieee80211_register_hw to fail (making the driver unusable).

Quoted 7 lines

This will tell kconfig to provide a warning if no rate control algorithms have been selected.  That'll at least warn the user; users that know that their drivers supply a rate control algorithm can safely ignore the warning, and those who don't know (or who expect to be using multiple drivers) can select a default RC algorithm.

You want to add Cc: [email protected] on the commit log, not on the e-mail.

Luis

#9 lore raw
Quoted 45 lines · Luis R. Rodriguez
Quoted 43 lines · Andres Salomon
Quoted 15 lines · On Mon, 8 Feb 2010 10:32:50 -0800 "Luis R. Rodriguez" <[email protected]> wrote:
Quoted 11 lines · Andres Salomon

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack w/ no rate control algorithm.  When RC_MINISTREL and RC_PID are both disabled, the RC_DEFAULT string (which rate.c uses as the fallback algorithm) will be "".  That'll cause the rate_control_alloc to fail, which will in turn cause ieee80211_register_hw to fail.  IOW, no driver will load.

This will tell kconfig to provide a warning if no rate control algorithms have been selected.  That'll at least warn the user that they're about to build a broken wireless stack.

Quoted 6 lines

Please Cc: [email protected] here as well, I think we've had this for a while.

Quoted 1 line

  Luis

Here's an updated patch.  I ended up just changing the wording.

Subject: [PATCH] mac80211: give warning if building w/out rate ctrl algorithm

I discovered that if EMBEDDED=y, one can accidentally build a mac80211 stack and drivers w/ no rate control algorithm.  For drivers like RTL8187 that don't supply their own RC algorithms, this will cause ieee80211_register_hw to fail (making the driver unusable).

This will tell kconfig to provide a warning if no rate control algorithms have been selected.  That'll at least warn the user; users that know that their drivers supply a rate control algorithm can safely ignore the warning, and those who don't know (or who expect to be using multiple drivers) can select a default RC algorithm.

Quoted 3 lines
Quoted 1 line

You want to add Cc: [email protected] on the commit log, not on the e-mail.

And repost the patch in a separate email, not in a reply that I have to munge before I can feed it to git...

John

Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.