Skip to contentSkip to conversation

devres/irq: Fix cross-referencing comments

PATCH Jean Delvare 2 participants 2 messages Feb 11, 2010 IRQ

lore
Share & tools
lore
#0 lore raw

Fix the reference (in comment) from devm_request_irq to devm_free_irq and back.

---
 kernel/irq/devres.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/irq/devres.c +2 -2
@@ -42,7 +42,7 @@ static int devm_irq_match(struct device
  *	automatically freed on driver detach.
  *
  *	If an IRQ allocated with this function needs to be freed
- *	separately, dev_free_irq() must be used.
+ *	separately, devm_free_irq() must be used.
  */
 int devm_request_threaded_irq(struct device *dev, unsigned int irq,
 			      irq_handler_t handler, irq_handler_t thread_fn,
@@ -81,7 +81,7 @@ EXPORT_SYMBOL(devm_request_threaded_irq)
  *	Except for the extra @dev argument, this function takes the
  *	same arguments and performs the same function as free_irq().
  *	This function instead of free_irq() should be used to manually
- *	free IRQs allocated with dev_request_irq().
+ *	free IRQs allocated with devm_request_irq().
  */
 void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id)
 {
Signature · 1 line
Jean Delvare
#1 lore raw
Quoted 20 lines · Jean Delvare

Fix the reference (in comment) from devm_request_irq to devm_free_irq and back.

---
 kernel/irq/devres.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/irq/devres.c +1 -1
@@ -42,7 +42,7 @@ static int devm_irq_match(struct device
  *	automatically freed on driver detach.
  *
  *	If an IRQ allocated with this function needs to be freed
- *	separately, dev_free_irq() must be used.
+ *	separately, devm_free_irq() must be used.
  */
 int devm_request_threaded_irq(struct device *dev, unsigned int irq,
 			      irq_handler_t handler, irq_handler_t thread_fn,

kernel/irq/devres.c EXPORT_SYMBOL(devm_request_threaded_irq) · line 87

Quoted 8 lines
kernel/irq/devres.c +1 -1
@@ -81,7 +81,7 @@ EXPORT_SYMBOL(devm_request_threaded_irq)
  *	Except for the extra @dev argument, this function takes the
  *	same arguments and performs the same function as free_irq().
  *	This function instead of free_irq() should be used to manually
- *	free IRQs allocated with dev_request_irq().
+ *	free IRQs allocated with devm_request_irq().
  */
 void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id)
 {

Hi Jean,

the latter has already been fixed in my tree. Applied the former hunk. Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.