xfs: fix inode pincount check in fsync
PATCH 1/1 xfs: fix inode pincount check in fsync
We need to hold the ilock to check the inode pincount safely. While we're at it also remove the check for ip->i_itemp->ili_last_lsn, a pinned inode always has it set.
Signed-off-by Christoph Hellwig <[email protected]>
fs/xfs/linux-2.6/xfs_file.c +4 -9
@@ -180,17 +180,12 @@ xfs_file_fsync(* disk yet, the inode will be still be pinned. If it is, * force the log. */ -xfs_iunlock (ip,XFS_ILOCK_SHARED );if (xfs_ipincount (ip)) { -if (ip->i_itemp->ili_last_lsn) { - error =_xfs_log_force_lsn (ip->i_mount, - ip->i_itemp->ili_last_lsn, -XFS_LOG_SYNC , &log_flushed); - }else { - error =_xfs_log_force (ip->i_mount, -XFS_LOG_SYNC , &log_flushed); - } + error =_xfs_log_force_lsn (ip->i_mount, + ip->i_itemp->ili_last_lsn, +XFS_LOG_SYNC , &log_flushed); } +xfs_iunlock (ip,XFS_ILOCK_SHARED ); }if (ip->i_mount->m_flags &XFS_MOUNT_BARRIER ) {
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 5 lines · Christoph Hellwig
We need to hold the ilock to check the inode pincount safely. While we're at it also remove the check for
ip->i_itemp->ili_last_lsn, a pinned inode always has it set.Signed-off-by Christoph Hellwig <[email protected]>
Looks good.
Reviewed-by Dave Chinner <[email protected]>
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs