Fix MSGCTL10() to avoid un-necessary cluttering of whole system with all PIDs
PATCH 1/1 Fix MSGCTL10() to avoid un-necessary cluttering of whole system with all PIDs
Hi,
msgctl10() un-necessarily eats up all the PIDs of the system leading to system becoming un-responsive. The changed no.s would better do the job.
---
testcases/kernel/syscalls/ipc/msgctl/msgctl10.c renamed from testcases/kernel/syscalls/ipc/msgctl/msgctl10.c.orig +2 -6
@@ -65,12 +65,8 @@ extern int Tst_count; /* Test Case counint exp_enos[] = {0 };/* List must end with 0 */ -#ifndef CONFIG_COLDFIRE -#define MAXNPROCS 1000000/* This value is set to an arbitrary high limit. */ -#else -#define MAXNPROCS 100000/* Coldfire can't deal with 1000000 */ -#endif -#define MAXNREPS 100000 +#define MAXNPROCS 10000/*These should be sufficient*/ +#define MAXNREPS 10000/*Else they srewup the system un-necessarily*/ #define FAIL 1#define PASS 0
---
Regards--
Subrata
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 6 lines · ----- "Subrata Modak
Hi,
msgctl10()un-necessarily eats up all the PIDs of the system leading to
system becoming un-responsive. The changed no.s would better do the job.
Hi, I see this patch is not included in ltp-full-20100331, will it be accepted in the future?
I tested msgctl10 testcase on RHEL5(2.6.18) and RHEL6(>2.6.31), Since /proc/sys/kernel/msgmni has increased from 10 (RHEL5) to thousands (RHEL6), the testing time will be several hours long. Applied this patch, the testing time can be lowed down to minutes.
Thanks,
Caspar
Quoted 42 lines
Signed-off-by Subrata Modak<[email protected]>---
---
ltp-full-20100131/testcases/kernel/syscalls/ipc/msgctl/msgctl10.c.orig2010-02-19 17:59:23.000000000 +0530 +++ ltp-full-20100131/testcases/kernel/syscalls/ipc/msgctl/msgctl10.c 2010-02-19 18:01:13.000000000 +0530testcases/kernel/syscalls/ipc/msgctl/msgctl10.c renamed from testcases/kernel/syscalls/ipc/msgctl/msgctl10.c.orig +0
-2@@ -65,12 +65,8 @@ extern int Tst_count; /* Test Case counint exp_enos[] = {0 };/* List must end with 0 */ -#ifndef CONFIG_COLDFIRE -#define MAXNPROCS 1000000/* This value is set to an arbitrary high limit. */
testcases/kernel/syscalls/ipc/msgctl/msgctl10.c renamed from testcases/kernel/syscalls/ipc/msgctl/msgctl10.c.orig +2
-4-#else -#define MAXNPROCS 100000/* Coldfire can't deal with 1000000 */ -#endif -#define MAXNREPS 100000 +#define MAXNPROCS 10000/*These should be sufficient*/ +#define MAXNREPS 10000/*Else they srewup the system un-necessarily*/
#define FAIL 1
#define PASS 0---
Regards--
Subrata------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Signature · 19 lines
/---------------------------------------\ | Name: Caspar Zhang | | Team: Kernel-QE | | IRC: czhang @ #kernel-qe, #eng-china | | Phone: +86-10-6260-8150 | | Cellphone: +86-1381-073-0090 | \---------------------------------------/ ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 6 lines · Caspar ZHANG
Quoted 2 lines · ----- "Subrata Modak
Hi,
Quoted 7 lines
Quoted 4 lines
msgctl10()un-necessarily eats up all the PIDs of the system leading to
system becoming un-responsive. The changed no.s would better do the job.Hi, I see this patch is not included in ltp-full-20100331, will it be accepted in the future?
Thanks for testing this patch. can you put your Acked-By / Tested-By ?
After that it will be included in master branch immediately.
-Rishi
Quoted 72 lines
I tested msgctl10 testcase on RHEL5(2.6.18) and RHEL6(>2.6.31), Since
/proc/sys/kernel/msgmnihas increased from 10 (RHEL5) to thousands (RHEL6), the testing time will be several hours long. Applied this patch, the testing time can be lowed down to minutes.Thanks,
CasparQuoted 42 lines
Signed-off-by Subrata Modak<[email protected]>---
---
ltp-full-20100131/testcases/kernel/syscalls/ipc/msgctl/msgctl10.c.orig2010-02-19 17:59:23.000000000 +0530 +++ ltp-full-20100131/testcases/kernel/syscalls/ipc/msgctl/msgctl10.c 2010-02-19 18:01:13.000000000 +0530testcases/kernel/syscalls/ipc/msgctl/msgctl10.c renamed from testcases/kernel/syscalls/ipc/msgctl/msgctl10.c.orig +0
-2@@ -65,12 +65,8 @@ extern int Tst_count; /* Test Case counint exp_enos[] = {0 };/* List must end with 0 */ -#ifndef CONFIG_COLDFIRE -#define MAXNPROCS 1000000/* This value is set to an arbitrary high limit. */
testcases/kernel/syscalls/ipc/msgctl/msgctl10.c renamed from testcases/kernel/syscalls/ipc/msgctl/msgctl10.c.orig +2
-4-#else -#define MAXNPROCS 100000/* Coldfire can't deal with 1000000 */ -#endif -#define MAXNREPS 100000 +#define MAXNPROCS 10000/*These should be sufficient*/ +#define MAXNREPS 10000/*Else they srewup the system un-necessarily*/
#define FAIL 1
#define PASS 0---
Regards--
Subrata------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-listSignature · 19 lines
/---------------------------------------\ | Name: Caspar Zhang | | Team: Kernel-QE | | IRC: czhang @ #kernel-qe, #eng-china | | Phone: +86-10-6260-8150 | | Cellphone: +86-1381-073-0090 | \---------------------------------------/ ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Signature · 16 lines
Thanks & Regards Rishi LTP Maintainer IBM, LTC, Bangalore Please join IRC #ltp @ irc.freenode.net ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list