Skip to contentSkip to conversation

: ckptinfo: Have -v imply -p option

PATCH In review Sukadev Bhattiprolu 2 participants 2 messages Feb 19, 2010 – Feb 22, 2010 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : ckptinfo: Have -v imply -p option

Do we even need the -p option ? It is not used without the -v at present. Can we drop the -p and have -v print filepos always ?

---
From: Sukadev Bhattiprolu <[email protected]>
Date: Fri, 19 Feb 2010 11:19:08 -0800
Subject: [PATCH 1/1] ckptinfo: Have -v imply -p

When the -v is chosen, user wants verbose debug information. The filepos would be useful to correlate with the kernel debug messages and does not clutter the output.

---
 ckptinfo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
ckptinfo.c +1 -1
index 6859742..be91b80 100644
@@ -135,7 +135,7 @@ int main(int argc, char *argv[])
 
 	if (args.verbose)
 		__verbose = 1;
-	if (args.position)
+	if (args.position || args.verbose)
 		__position = 1;
 
 	argc -= optind;
Signature · 1 line
1.6.6.1
#2 lore raw
In reply to a message not in the archive
Quoted 2 lines · Sukadev Bhattiprolu

Do we even need the -p option ? It is not used without the -v at present. Can we drop the -p and have -v print filepos always ?

Ok. I'll do that.

Oren.

Quoted 28 lines

---
From: Sukadev Bhattiprolu <[email protected]>
Date: Fri, 19 Feb 2010 11:19:08 -0800
Subject: [PATCH 1/1] ckptinfo: Have -v imply -p

When the -v is chosen, user wants verbose debug information. The filepos would be useful to correlate with the kernel debug messages and does not clutter the output.

---
 ckptinfo.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
ckptinfo.c +1 -1
index 6859742..be91b80 100644
@@ -135,7 +135,7 @@ int main(int argc, char *argv[])
 
 	if (args.verbose)
 		__verbose = 1;
-	if (args.position)
+	if (args.position || args.verbose)
 		__position = 1;
 
 	argc -= optind;