Skip to contentSkip to conversation

sysctl extern cleanup - mm

PATCH In review Dave Young 2 participants 2 messages Feb 20, 2010 – Feb 21, 2010

Subsystems (3)
lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 6/18 sysctl extern cleanup - mm

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move min_free_kbytes extern declaration to linux/mm.h

---
 include/linux/mm.h |    1 +
 kernel/sysctl.c    |    1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
include/linux/mm.h +1 -0
@@ -31,6 +31,7 @@ extern int page_cluster;
 
 #ifdef CONFIG_SYSCTL
 extern int sysctl_legacy_va_layout;
+extern int min_free_kbytes;
 #else
 #define sysctl_legacy_va_layout 0
 #endif
kernel/sysctl.c +0 -1
@@ -72,7 +72,6 @@
 #if defined(CONFIG_SYSCTL)
 
 /* External variables not in a header file. */
-extern int min_free_kbytes;
 extern int compat_log;
 extern int latencytop_enabled;
 extern int sysctl_nr_open_min, sysctl_nr_open_max;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#1 lore raw
Quoted 5 lines · Dave Young

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move min_free_kbytes extern declaration to linux/mm.h

It should be moved to include/linux/mmzone.h, that's where the sysctl handler is declared.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>