Skip to contentSkip to conversation

sysctl extern cleanup - compat

PATCH In review Dave Young 2 participants 3 messages Feb 20, 2010 Proc sysctl

lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 7/18 sysctl extern cleanup - compat

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move compat_log extern declaration to linux/compat.h

Signed-off-by Dave Young <[email protected]>
---
 include/linux/compat.h |    3 +++
 kernel/sysctl.c        |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
include/linux/compat.h +3 -0
@@ -17,6 +17,9 @@
 #include <asm/siginfo.h>
 #include <asm/signal.h>
 
+#ifdef CONFIG_SYSCTL
+extern int compat_log;
+#endif
 #define compat_jiffies_to_clock_t(x)	\
 		(((unsigned long)(x) * COMPAT_USER_HZ) / HZ)
kernel/sysctl.c +1 -1
@@ -58,6 +58,7 @@
 #include <linux/threads.h>
 #include <linux/binfmts.h>
 #include <linux/pid.h>
+#include <linux/compat.h>
 
 #include <asm/uaccess.h>
 #include <asm/processor.h>

@@ -72,7 +73,6 @@
 #if defined(CONFIG_SYSCTL)
 
 /* External variables not in a header file. */
-extern int compat_log;
 extern int latencytop_enabled;
 extern int sysctl_nr_open_min, sysctl_nr_open_max;
 #ifdef CONFIG_RCU_TORTURE_TEST
#1 lore raw
Quoted 6 lines · On Saturday 20 February 2010 15:13:28 Dave Young wrote:

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move compat_log extern declaration to linux/compat.h

Signed-off-by Dave Young <[email protected]>

Good idea in principle, but please don't enclose the extern declaration in #ifdef:

include/linux/compat.h line 24

Quoted 11 lines
include/linux/compat.h +3 -0
@@ -17,6 +17,9 @@
 #include <asm/siginfo.h>
 #include <asm/signal.h>
 
+#ifdef CONFIG_SYSCTL
+extern int compat_log;
+#endif
 #define compat_jiffies_to_clock_t(x)	\
 		(((unsigned long)(x) * COMPAT_USER_HZ) / HZ)

This will force a rebuild of everything that #includes linux/compat.h when CONFIG_SYSCTL changes, while nothing really changes.

Obviously, the same goes for the entire series.

Arnd

author
#2 lore raw
Quoted 26 lines · Arnd Bergmann
Quoted 6 lines · On Saturday 20 February 2010 15:13:28 Dave Young wrote:

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move compat_log extern declaration to linux/compat.h

Signed-off-by Dave Young <[email protected]>

Good idea in principle, but please don't enclose the extern declaration in #ifdef:

include/linux/compat.h       2010-02-20 14:24:30.405627048 +0800 line 24

Quoted 11 lines
include/linux/compat.h       2010-02-20 14:24:30.405627048 +0800 renamed from include/linux/compat.h  2010-02-20 14:02:24.334925488 +0800 +3 -0
@@ -17,6 +17,9 @@
  #include <asm/siginfo.h>
  #include <asm/signal.h>
 
+#ifdef CONFIG_SYSCTL
+extern int compat_log;
+#endif
  #define compat_jiffies_to_clock_t(x) \
               (((unsigned long)(x) * COMPAT_USER_HZ) / HZ)

This will force a rebuild of everything that #includes linux/compat.h when CONFIG_SYSCTL changes, while nothing really changes.

Quoted 1 line

Obviously, the same goes for the entire series.

Yes, indeed. Thanks for the comments.

Actually I need resend the whole patchset with a updated version.

Quoted 8 lines

       Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Signature · 2 lines
Regards
dave