Skip to contentSkip to conversation

sysctl extern cleanup - rcu

PATCH In review Dave Young 2 participants 2 messages Feb 20, 2010

Subsystems (2)
RCU Proc sysctl
lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 10/18 sysctl extern cleanup - rcu

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move rcutorture_runnable extern declaration to linux/rcupdate.h

Signed-off-by Dave Young <[email protected]>
---
 include/linux/rcupdate.h |    6 ++++++
 kernel/sysctl.c          |    3 ---
 2 files changed, 6 insertions(+), 3 deletions(-)
include/linux/rcupdate.h +6 -0
@@ -41,6 +41,12 @@
 #include <linux/lockdep.h>
 #include <linux/completion.h>
 
+#ifdef CONFIG_SYSCTL
+#ifdef CONFIG_RCU_TORTURE_TEST
+extern int rcutorture_runnable;
+#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
+#endif
+
 /**
  * struct rcu_head - callback structure for use with RCU
  * @next: next update requests in a list
kernel/sysctl.c +0 -3
@@ -75,9 +75,6 @@
 #if defined(CONFIG_SYSCTL)
 
 /* External variables not in a header file. */
-#ifdef CONFIG_RCU_TORTURE_TEST
-extern int rcutorture_runnable;
-#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
 #ifdef CONFIG_BLOCK
 extern int blk_iopoll_enabled;
 #endif
maintainer Acked-by on v1 10/18
#1 lore raw
Quoted 6 lines · Dave Young

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move rcutorture_runnable extern declaration to linux/rcupdate.h

Signed-off-by Dave Young <[email protected]>
Acked-by Josh Triplett <[email protected]>

That said, this could probably become something other than a sysctl easily enough; debugfs or writable module parameters come to mind.

- Josh Triplett