Skip to contentSkip to conversation

sysctl extern cleanup - module

PATCH In review Dave Young 1 participant 1 message Feb 20, 2010

Subsystems (2)
Proc sysctl Module support
lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 12/18 sysctl extern cleanup - module

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move modprobe_path extern declaration to linux/kmod.h Move modules_disabled extern declaration to linux/module.h

Signed-off-by Dave Young <[email protected]>
---
 include/linux/kmod.h   |    3 +++
 include/linux/module.h |    6 ++++++
 kernel/sysctl.c        |    4 ----
 3 files changed, 9 insertions(+), 4 deletions(-)
include/linux/module.h +6 -0
@@ -34,6 +34,12 @@
 
 #define MODULE_NAME_LEN MAX_PARAM_PREFIX_LEN
 
+#ifdef CONFIG_SYSCTL
+#ifdef CONFIG_MODULES
+extern int modules_disabled;
+#endif
+#endif
+
 struct kernel_symbol
 {
 	unsigned long value;
kernel/sysctl.c +0 -4
@@ -100,10 +100,6 @@ static int min_percpu_pagelist_fract = 8
 
 static int ngroups_max = NGROUPS_MAX;
 
-#ifdef CONFIG_MODULES
-extern char *modprobe_path;
-extern int modules_disabled;
-#endif
 #ifdef CONFIG_CHR_DEV_SG
 extern int sg_big_buff;
 #endif
include/linux/kmod.h +3 -0
@@ -28,6 +28,9 @@
 #define KMOD_PATH_LEN 256
 
 #ifdef CONFIG_MODULES
+#ifdef CONFIG_SYSCTL
+extern char *modprobe_path;
+#endif
 /* modprobe exit status on success, -ve on error.  Return value
  * usually useless though. */
 extern int __request_module(bool wait, const char *name, ...) \