Skip to contentSkip to conversation

sysctl extern cleanup - inotify

PATCH In review Dave Young 1 participant 1 message Feb 20, 2010

Subsystems (2)
lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 18/18 sysctl extern cleanup - inotify

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move inotify_table extern declaration to linux/inotify.h

---
 include/linux/inotify.h |    6 ++++++
 kernel/sysctl.c         |    4 +---
 2 files changed, 7 insertions(+), 3 deletions(-)
kernel/sysctl.c +1 -3
@@ -45,6 +45,7 @@
 #include <linux/limits.h>
 #include <linux/dcache.h>
 #include <linux/dnotify.h>
+#include <linux/inotify.h>
 #include <linux/syscalls.h>
 #include <linux/vmstat.h>
 #include <linux/nfs_fs.h>
@@ -160,9 +161,6 @@ static struct ctl_table fs_table[];
 static struct ctl_table debug_table[];
 static struct ctl_table dev_table[];
 extern struct ctl_table random_table[];
-#ifdef CONFIG_INOTIFY_USER
-extern struct ctl_table inotify_table[];
-#endif
 
 /* The default sysctl tables: */
 
include/linux/inotify.h +6 -0
@@ -69,4 +69,10 @@ struct inotify_event {
 #define IN_CLOEXEC O_CLOEXEC
 #define IN_NONBLOCK O_NONBLOCK
 
+#ifdef __KERNEL__
+#if defined(CONFIG_INOTIFY_USER) && defined(CONFIG_SYSCTL)
+extern struct ctl_table inotify_table[];
+#endif
+#endif
+
 #endif	/* _LINUX_INOTIFY_H */