Skip to contentSkip to conversation

sysctl extern cleanup - sg

PATCH In review Dave Young 1 participant 1 message Feb 21, 2010

Subsystems (3)
SCSI Proc sysctl SCSI SG driver
lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 12/17 sysctl extern cleanup - sg

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move sg_big_buff extern declaration to scsi/sg.h

Signed-off-by Dave Young <[email protected]>
---
 include/scsi/sg.h |    3 +++
 kernel/sysctl.c   |    7 +++----
 2 files changed, 6 insertions(+), 4 deletions(-)
include/scsi/sg.h +3 -0
@@ -70,6 +70,9 @@ Major new features in SG 3.x driver (cf 
  (for the lk 2.2 series).
 */
 
+#ifdef __KERNEL__
+extern int sg_big_buff; /* for sysctl */
+#endif
 
 /* New interface introduced in the 3.x SG drivers follows */
kernel/sysctl.c +3 -4
@@ -63,6 +63,9 @@
 #ifdef CONFIG_BLOCK
 #include <linux/blk-iopoll.h>
 #endif
+#ifdef CONFIG_CHR_DEV_SG
+#include <scsi/sg.h>
+#endif
 
 #include <asm/uaccess.h>
 #include <asm/processor.h>

@@ -104,10 +107,6 @@ static int min_percpu_pagelist_fract = 8
 
 static int ngroups_max = NGROUPS_MAX;
 
-#ifdef CONFIG_CHR_DEV_SG
-extern int sg_big_buff;
-#endif
-
 #ifdef CONFIG_SPARC
 #include <asm/system.h>
 #endif