Skip to contentSkip to conversation

sysctl extern cleanup - poll

PATCH In review Dave Young 1 participant 1 message Feb 21, 2010 Proc sysctl

lore
Share & tools
lore

Dave Young

author
#0 lore raw

PATCH 16/17 sysctl extern cleanup - poll

Extern declarations in sysctl.c should be move to their own head file, and then include them in relavant .c files.

Move epoll_table extern declaration to linux/poll.h

---
 include/linux/poll.h |    2 ++
 kernel/sysctl.c      |    6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)
include/linux/poll.h +2 -0
@@ -10,8 +10,10 @@
 #include <linux/wait.h>
 #include <linux/string.h>
 #include <linux/fs.h>
+#include <linux/sysctl.h>
 #include <asm/uaccess.h>
 
+extern struct ctl_table epoll_table[]; /* for sysctl */
 /* ~832 bytes of stack space used max in sys_select/sys_poll before allocating
    additional memory. */
 #define MAX_STACK_ALLOC 832
kernel/sysctl.c +3 -3
@@ -72,6 +72,9 @@
 #if defined(CONFIG_PROVE_LOCKING) || defined(CONFIG_LOCK_STAT)
 #include <linux/lockdep.h>
 #endif
+#ifdef CONFIG_EPOLL
+#include <linux/poll.h>
+#endif
 #ifdef CONFIG_CHR_DEV_SG
 #include <scsi/sg.h>
 #endif
@@ -174,9 +177,6 @@ extern struct ctl_table random_table[];
 #ifdef CONFIG_INOTIFY_USER
 extern struct ctl_table inotify_table[];
 #endif
-#ifdef CONFIG_EPOLL
-extern struct ctl_table epoll_table[];
-#endif
 
 /* The default sysctl tables: */