repost [PATCH 1/1] mISDN: Add PCI ID for HFC-4S Beronet Card PCIe
A few subdevice IDs seem to have been dropped when hfc_multi was included upstream, just compare the list at
http://www.openvox.cn/viewvc/misdn/trunk/hfc_multi.c?revision=75&view=annotate#l175
with the IDs in drivers/isdn/hardware/mISDN/hfcmulti.c
I only have access to the 0xB762 hardware, so I only added that ID.
---
*BUMP*
Repost, first posted
Date: Wed, 3 Feb 2010 22:20:55 +0100
Message-ID: <[email protected]>
As all our daily phone calls run over these cards, I can confirm this particular card as working just fine, once the driver feels responsible. But someone should consider to also include the rest of the IDs, unless there has been a reason to drop them.
drivers/isdn/hardware/mISDN/hfcmulti.c +3 -0
@@ -5265,6 +5265,7 @@ static const struct hm_map hfcm_map[] = {/*31*/ {VENDOR_CCD ,"XHFC-4S Speech Design" ,5 ,4 ,0 ,0 ,0 ,0 , HFC_IO_MODE_EMBSD, XHFC_IRQ}, /*32*/ {VENDOR_JH, "HFC-8S (junghanns)", 8, 8, 1, 0, 0, 0, 0, 0}, +/*33*/ {VENDOR_CCD, "HFC-4S Beronet Card PCIe", 4, 4, 1, 0, 0, 0, 0, 0}, };#undef H
@@ -5300,6 +5301,8 @@ static struct pci_device_id hfmultipci_ids[] __devinitdata = { PCI_SUBDEVICE_ID_CCD_OV4S, 0, 0, H(28)}, /* OpenVox 4 */ { PCI_VENDOR_ID_CCD, PCI_DEVICE_ID_CCD_HFC4S, PCI_VENDOR_ID_CCD, PCI_SUBDEVICE_ID_CCD_OV2S, 0, 0, H(29)}, /* OpenVox 2 */ + { PCI_VENDOR_ID_CCD, PCI_DEVICE_ID_CCD_HFC4S, PCI_VENDOR_ID_CCD, + PCI_SUBDEVICE_ID_CCD_BN4SE, 0, 0, H(33)}, /* BN4S PCIe *//* Cards with HFC-8S Chip */ { PCI_VENDOR_ID_CCD, PCI_DEVICE_ID_CCD_HFC8S, PCI_VENDOR_ID_CCD,
include/linux/pci_ids.h +1 -0
@@ -1924,6 +1924,7 @@#define PCI_SUBDEVICE_ID_CCD_HFC8S 0xB622#define PCI_DEVICE_ID_CCD_B700 0xb700#define PCI_DEVICE_ID_CCD_B701 0xb701 +#define PCI_SUBDEVICE_ID_CCD_BN4SE 0xb762#define PCI_SUBDEVICE_ID_CCD_HFCE1 0xC523#define PCI_SUBDEVICE_ID_CCD_OV2S 0xE884#define PCI_SUBDEVICE_ID_CCD_OV4S 0xE888
I will send a new version with all IDs.
So far I see only the 2 PCIe cards from Beronet are missing (0xb761,0xb762).
Karsten
Quoted 59 lines · On Montag, 1. März 2010 11:38:45 Lars Ellenberg wrote:
A few subdevice IDs seem to have been dropped when
hfc_multiwas included upstream, just compare the list at
http://www.openvox.cn/viewvc/misdn/trunk/hfc_multi.c?revision=75&view=annot
ate#l175 with the IDs indrivers/isdn/hardware/mISDN/hfcmulti.cI only have access to the
0xB762hardware, so I only added that ID.Signed-off-by Lars Ellenberg <[email protected]>---
*BUMP*
Repost, first posted
Date: Wed, 3 Feb 2010 22:20:55 +0100
Message-ID: <[email protected]>As all our daily phone calls run over these cards, I can confirm this particular card as working just fine, once the driver feels responsible. But someone should consider to also include the rest of the IDs, unless there has been a reason to drop them.
(quoted diff) +0
-0b/drivers/isdn/hardware/mISDN/hfcmulti.c index 1a1420d..446a29c 100644drivers/isdn/hardware/mISDN/hfcmulti.c +3
-0@@ -5265,6 +5265,7 @@ static const struct hm_map hfcm_map[] = {/*31*/ {VENDOR_CCD ,"XHFC-4S Speech Design" ,5 ,4 ,0 ,0 ,0 ,0 , HFC_IO_MODE_EMBSD, XHFC_IRQ}, /*32*/ {VENDOR_JH, "HFC-8S (junghanns)", 8, 8, 1, 0, 0, 0, 0, 0}, +/*33*/ {VENDOR_CCD, "HFC-4S Beronet Card PCIe", 4, 4, 1, 0, 0, 0, 0, 0}, };#undef H@@ -5300,6 +5301,8 @@ static struct pci_device_id hfmultipci_ids[] __devinitdata = { PCI_SUBDEVICE_ID_CCD_OV4S, 0, 0, H(28)}, /* OpenVox 4 */ { PCI_VENDOR_ID_CCD, PCI_DEVICE_ID_CCD_HFC4S, PCI_VENDOR_ID_CCD, PCI_SUBDEVICE_ID_CCD_OV2S, 0, 0, H(29)}, /* OpenVox 2 */ + { PCI_VENDOR_ID_CCD, PCI_DEVICE_ID_CCD_HFC4S, PCI_VENDOR_ID_CCD, + PCI_SUBDEVICE_ID_CCD_BN4SE, 0, 0, H(33)}, /* BN4S PCIe *//* Cards with HFC-8S Chip */ { PCI_VENDOR_ID_CCD, PCI_DEVICE_ID_CCD_HFC8S, PCI_VENDOR_ID_CCD,include/linux/pci_ids.h +1
-0@@ -1924,6 +1924,7 @@#define PCI_SUBDEVICE_ID_CCD_HFC8S 0xB622#define PCI_DEVICE_ID_CCD_B700 0xb700#define PCI_DEVICE_ID_CCD_B701 0xb701 +#define PCI_SUBDEVICE_ID_CCD_BN4SE 0xb762#define PCI_SUBDEVICE_ID_CCD_HFCE1 0xC523#define PCI_SUBDEVICE_ID_CCD_OV2S 0xE884#define PCI_SUBDEVICE_ID_CCD_OV4S 0xE888