riptide: clean up while loop
Subsystems (2)
PATCH 1/1 riptide: clean up while loop
If getpaths() returned an odd number this would be a buffer under-run and an endless loop. It turns out that getpaths() can only return even numbers, but let's make it easy for people auditing code. With the new code you don't need to look at getpaths().
This silences a smatch warning.
Signed-off-by Dan Carpenter <[email protected]>
sound/pci/riptide/riptide.c +3 -3
@@ -1974,9 +1974,9 @@ snd_riptide_proc_read(struct snd_info_entry *entry, }snd_iprintf (buffer,"Paths:\n" ); i =getpaths (cif, p); -while (i--) { -snd_iprintf (buffer,"%x->%x " , p[i -1 ], p[i]); - i--; +while (i >=2 ) { + i -=2 ; +snd_iprintf (buffer,"%x->%x " , p[i], p[i +1 ]); }snd_iprintf (buffer,"\n" ); }
At Wed, 3 Mar 2010 10:13:49 +0300,
Quoted 9 lines · Dan Carpenter
If
getpaths()returned an odd number this would be a buffer under-run and an endless loop. It turns out thatgetpaths()can only return even numbers, but let's make it easy for people auditing code. With the new code you don't need to look atgetpaths().This silences a smatch warning.
Signed-off-by Dan Carpenter <[email protected]>
Applied now. Thanks.
Takashi
Quoted 18 lines
sound/pci/riptide/riptide.c +3
-3@@ -1974,9 +1974,9 @@ snd_riptide_proc_read(struct snd_info_entry *entry, }snd_iprintf (buffer,"Paths:\n" ); i =getpaths (cif, p); -while (i--) { -snd_iprintf (buffer,"%x->%x " , p[i -1 ], p[i]); - i--; +while (i >=2 ) { + i -=2 ; +snd_iprintf (buffer,"%x->%x " , p[i], p[i +1 ]); }snd_iprintf (buffer,"\n" ); }