Skip to contentSkip to conversation

cassini: fix off by one

PATCH Applied Dan Carpenter 3 participants 4 messages Mar 3, 2010

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 cassini: fix off by one

There are only 6 link_modes.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/cassini.c +1 -1
index 7cbcfb0..9bd155e 100644
@@ -5072,7 +5072,7 @@ static int __devinit cas_init_one(struct pci_dev *pdev,
 	INIT_WORK(&cp->reset_task, cas_reset_task);
 
 	/* Default link parameters */
-	if (link_mode >= 0 && link_mode <= 6)
+	if (link_mode >= 0 && link_mode < 6)
 		cp->link_cntl = link_modes[link_mode];
 	else
 		cp->link_cntl = BMCR_ANENABLE;
#2 lore raw

Hello Dave and Dan,

Quoted 8 lines · David Miller

From: Dan Carpenter <[email protected]>
Date: Wed, 3 Mar 2010 11:22:41 +0300

Quoted 3 lines

There are only 6 link_modes.

Signed-off-by Dan Carpenter <[email protected]>

Applied.

I am curious should we add these kind of email address in git log. error27 seems error to me ;-)

Can we make Signed-off address little bit more sensible.

Thanks,
--
Jaswinder

maintainer
#3 lore raw

From: Jaswinder Singh Rajput <[email protected]>
Date: Wed, 3 Mar 2010 20:40:18 +0530

Quoted 8 lines

Hello Dave and Dan,

Quoted 5 lines · David Miller

From: Dan Carpenter <[email protected]>
Date: Wed, 3 Mar 2010 11:22:41 +0300

Quoted 2 lines

There are only 6 link_modes.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Dan Carpenter <[email protected]>

Applied.

I am curious should we add these kind of email address in git log. error27 seems error to me ;-)

Can we make Signed-off address little bit more sensible.

Some people have silly email addresses, that is their choice.

I can't see any reason to apply censorship to an email address just because the character sequences in it have some kind of meaning.

The email address I was using up until 6 or 7 years ago used a host name that meant "shit" in the Polish languange.

Maybe I should have been censored too?