Skip to contentSkip to conversation

vga_switcheroo: locking question in vga_switcheroo_debugfs_write()

DISCUSSION Dan Carpenter 1 participant 1 message Mar 6, 2010

lore
Share & tools
lore
#0 lore raw

Hi Dave,

drivers/gpu/vga/vga_switcheroo.c +362 vga_switcheroo_debugfs_write(101)
277 mutex_lock(&vgasr_mutex);
278
279 if (!vgasr_priv.active)
280 return -EINVAL;

Is there a reason we return with the lock held here? The other returns from this function don't have the lock held. I looked through the rest of the file but didn't see any clues.

regards,
dan carpenter