Skip to contentSkip to conversation

bug report: netpoll: allow execution of multiple rx_hooks per interface

DISCUSSION Daniel Borkmann 2 participants 2 messages Mar 10, 2010 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Hi Dan,

Quoted 4 lines · Dan Carpenter

Smatch complains about 508e14b4a4f: netpoll: allow execution of multiple rx_hooks per interface

net/core/netpoll.c +840 netpoll_setup(124) error: potential null dereference 'npinfo'. (kmalloc returns null)

Quoted 12 lines
   839          if (!ndev->npinfo) {
   840                  spin_lock_irqsave(&npinfo->rx_lock, flags);

	npinfo can be null here if the kmalloc() failed.

   841                  list_for_each_entry_safe(npe, tmp, &npinfo->rx_np, rx) {
   842                          npe->dev = NULL;
   843                  }
   844                  spin_unlock_irqrestore(&npinfo->rx_lock, flags);
   845
   846                  kfree(npinfo);
   847          }

Sorry for the late reply, I'm currently on holiday and have hardly access to the Internet. I'll fix the problem as soon as possible.

You'll hear from me.

Thanks,
Daniel

maintainer
#2 lore raw

From: Daniel Borkmann <[email protected]>
Date: Wed, 10 Mar 2010 12:13:31 +0100

Quoted 4 lines

Sorry for the late reply, I'm currently on holiday and have hardly access to the Internet. I'll fix the problem as soon as possible.

You'll hear from me.

Thanks.