goku_udc: potential null dereference

PATCH New Dan Carpenter 1 participant 1 message Mar 6, 2010

Subsystems (2)

USB Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-03-06 11:08 UTC #0 lore raw

PATCH 1/1 goku_udc: potential null dereference

"dev" is always null here. In the end it's only used to get the pci_name() of "pdev" which is redundant information and so I removed it.

Signed-off-by Dan Carpenter <[email protected]>

drivers/usb/gadget/goku_udc.c +1 -1

index e8edc64..1088d08 100644
@@ -1768,7 +1768,7 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	 * usb_gadget_driver_{register,unregister}() must change.
 	 */
 	if (the_controller) {
-		WARNING(dev, "ignoring %s\n", pci_name(pdev));
+		pr_warning("ignoring %s\n", pci_name(pdev));
 		return -EBUSY;
 	}
 	if (!pdev->irq) {