bridge: cleanup: remove unneed check
Subsystems (4)
PATCH 1/1 bridge: cleanup: remove unneed check
We dereference "port" on the lines immediately before and immediately after the test so port should hopefully never be null here.
Signed-off-by Dan Carpenter <[email protected]>
net/bridge/br_multicast.c +2 -2
@@ -627,8 +627,8 @@ static void br_multicast_port_query_expired(unsigned long data)struct net_bridge *br = port->br;spin_lock (&br->multicast_lock); -if (port && (port->state ==BR_STATE_DISABLED || - port->state ==BR_STATE_BLOCKING )) +if (port->state ==BR_STATE_DISABLED || + port->state ==BR_STATE_BLOCKING ) goto out; if (port->multicast_startup_queries_sent <
Quoted 4 lines · Dan Carpenter
We dereference "port" on the lines immediately before and immediately after the test so port should hopefully never be null here.
Signed-off-by Dan Carpenter <[email protected]>
Signed-off-by Herbert Xu <[email protected]>
Yes this looks correct to me.
Thanks,
Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txtFrom: Herbert Xu <[email protected]>
Date: Sat, 6 Mar 2010 20:20:32 +0800
Quoted 9 lines · Dan Carpenter
Quoted 4 lines
We dereference "port" on the lines immediately before and immediately after the test so port should hopefully never be null here.
Signed-off-by Dan Carpenter <[email protected]>Signed-off-by Herbert Xu <[email protected]>Yes this looks correct to me.
Applied.