bluetooth: storing negative values as unsigned char

PATCH In review Dan Carpenter 2 participants 2 messages Mar 8, 2010 – Mar 9, 2010

Subsystems (2)

Bluetooth drivers Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-03-08 12:15 UTC #0 lore raw

PATCH 1/1 bluetooth: storing negative values as unsigned char

This is mostly cleanup. There is only one caller and it just checks for non-zero return values. Still "ret" should be int because we want to return -EINVAL on errors.

Signed-off-by Dan Carpenter <[email protected]>

drivers/bluetooth/btmrvl_main.c +1 -1

index 53a43ad..49ec89c 100644
@@ -66,7 +66,7 @@ int btmrvl_process_event(struct btmrvl_private *priv, struct sk_buff *skb)
 {
 	struct btmrvl_adapter *adapter = priv->adapter;
 	struct btmrvl_event *event;
-	u8 ret = 0;
+	int ret = 0;
 
 	event = (struct btmrvl_event *) skb->data;
 	if (event->ec != 0xff) {

Marcel Holtmann

maintainer

2010-03-09 00:54 UTC #1 lore raw

Hi Dan,

Quoted 3 lines

This is mostly cleanup. There is only one caller and it just checks for non-zero return values. Still "ret" should be int because we want to return -EINVAL on errors.

patch has been applied. Thanks.

Regards

Marcel