Skip to contentSkip to conversation

mfd: Fix sm501 requested region size

PATCH In review Samuel Ortiz 3 participants 3 messages Mar 9, 2010 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: Fix sm501 requested region size

We should only request for the MFD used region, not the whole thing.

---
 drivers/mfd/sm501.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/sm501.c +2 -2
index dc9ea95..497712f 100644
@@ -1430,7 +1430,7 @@ static int __devinit sm501_plat_probe(struct platform_device *dev)
 	}
 
 	sm->regs_claim = request_mem_region(sm->io_res->start,
-					    resource_size(sm->io_res), "sm501");
+					    0x100, "sm501");
 
 	if (sm->regs_claim == NULL) {
 		dev_err(&dev->dev, "cannot claim registers\n");
@@ -1644,7 +1644,7 @@ static int __devinit sm501_pci_probe(struct pci_dev *dev,
 	sm->mem_res = &dev->resource[0];
 
 	sm->regs_claim = request_mem_region(sm->io_res->start,
-					    resource_size(sm->io_res), "sm501");
+					    0x100, "sm501");
 	if (sm->regs_claim == NULL) {
 		dev_err(&dev->dev, "cannot claim registers\n");
 		err= -EBUSY;
Signature · 5 lines
1.6.3.3

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
Reviewed-by on v1 1/1
#2 lore raw
In reply to Samuel Ortiz
Quoted 4 lines · Samuel Ortiz

We should only request for the MFD used region, not the whole thing.

Sorry about that...

Quoted 26 lines
---
 drivers/mfd/sm501.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/sm501.c +2 -2
index dc9ea95..497712f 100644
@@ -1430,7 +1430,7 @@ static int __devinit sm501_plat_probe(struct platform_device *dev)
 	}
 
 	sm->regs_claim = request_mem_region(sm->io_res->start,
-					    resource_size(sm->io_res), "sm501");
+					    0x100, "sm501");
 
 	if (sm->regs_claim == NULL) {
 		dev_err(&dev->dev, "cannot claim registers\n");
@@ -1644,7 +1644,7 @@ static int __devinit sm501_pci_probe(struct pci_dev *dev,
 	sm->mem_res = &dev->resource[0];
 
 	sm->regs_claim = request_mem_region(sm->io_res->start,
-					    resource_size(sm->io_res), "sm501");
+					    0x100, "sm501");
 	if (sm->regs_claim == NULL) {
 		dev_err(&dev->dev, "cannot claim registers\n");
 		err= -EBUSY;