Skip to contentSkip to conversation

call_usermodehelper: no need to unblock the signals

PATCH New Oleg Nesterov 1 participant 1 message Mar 9, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 call_usermodehelper: no need to unblock the signals

____call_usermodehelper() correctly calls flush_signal_handlers() to set SIG_DFL, but sigemptyset(->blocked) and recalc_sigpending() are not needed.

This kthread was forked by workqueue thread, all signals must be unblocked and ignored, no pending signal is possible.

---

 kernel/kmod.c |    3 ---
 1 file changed, 3 deletions(-)
kernel/kmod.c renamed from kernel/kmod.c~1_SIGNALS +0 -3
@@ -153,11 +153,8 @@ static int ____call_usermodehelper(void 
 	struct subprocess_info *sub_info = data;
 	int retval;
 
-	/* Unblock all signals */
 	spin_lock_irq(&current->sighand->siglock);
 	flush_signal_handlers(current, 1);
-	sigemptyset(&current->blocked);
-	recalc_sigpending();
 	spin_unlock_irq(&current->sighand->siglock);
 
 	/* We can run anywhere, unlike our parent keventd(). */