Skip to contentSkip to conversation

ARM: Add support for 10 hardirq bits

PATCH New Magnus Damm 3 participants 9 messages Mar 10, 2010 – May 19, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Add support for 10 hardirq bits

From: Magnus Damm <[email protected]>

This patch adds support for 10 hardirq bits to
the ARM architecture. Needed by the SH-Mobile
ARM processor sh7372 that has more than 512 IRQs.

---

 arch/arm/include/asm/hardirq.h |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/include/asm/hardirq.h +3 -1
@@ -12,7 +12,9 @@ typedef struct {
 
 #include <linux/irq_cpustat.h>	/* Standard mappings for irq_cpustat_t above */
 
-#if NR_IRQS > 256
+#if NR_IRQS > 512
+#define HARDIRQ_BITS	10
+#elif NR_IRQS > 256
 #define HARDIRQ_BITS	9
 #else
 #define HARDIRQ_BITS	8
#1 lore raw

PATCH 1/1 ARM: Add support for 10 hardirq bits

Quoted 22 lines · Magnus Damm

From: Magnus Damm <[email protected]>

This patch adds support for 10 hardirq bits to
the ARM architecture. Needed by the SH-Mobile
ARM processor sh7372 that has more than 512 IRQs.

---

?arch/arm/include/asm/hardirq.h | ? ?4 +++-
?1 file changed, 3 insertions(+), 1 deletion(-)

arch/arm/include/asm/hardirq.h 2010-03-09 21:08:10.000000000 +0900 renamed from arch/arm/include/asm/hardirq.h +0 -0
@@ -12,7 +12,9 @@ typedef struct {
 

?#include <linux/irq_cpustat.h> /* Standard mappings for irq_cpustat_t above */

arch/arm/include/asm/hardirq.h 2010-03-09 21:08:10.000000000 +0900 renamed from arch/arm/include/asm/hardirq.h +3 -1
-#if NR_IRQS > 256
+#if NR_IRQS > 512
+#define HARDIRQ_BITS ? 10
+#elif NR_IRQS > 256
Quoted 4 lines

?#define HARDIRQ_BITS ? 9
?#else
?#define HARDIRQ_BITS ? 8

Hi Russell,

Good to hear that you are back online. Do you want me to rework this patch somehow, or is it ready to be queued for upstream merge? I'm asking because I have a pile of patches that depend on this one.

Cheers,

/ magnus

#2 lore raw

PATCH 1/1 ARM: Add support for 10 hardirq bits

Quoted 30 lines · Magnus Damm
Quoted 22 lines · Magnus Damm

From: Magnus Damm <[email protected]>

This patch adds support for 10 hardirq bits to
the ARM architecture. Needed by the SH-Mobile
ARM processor sh7372 that has more than 512 IRQs.

---

?arch/arm/include/asm/hardirq.h | ? ?4 +++-
?1 file changed, 3 insertions(+), 1 deletion(-)

arch/arm/include/asm/hardirq.h 2010-03-09 21:08:10.000000000 +0900 renamed from arch/arm/include/asm/hardirq.h +0 -0
@@ -12,7 +12,9 @@ typedef struct {
 

?#include <linux/irq_cpustat.h> /* Standard mappings for irq_cpustat_t above */

arch/arm/include/asm/hardirq.h 2010-03-09 21:08:10.000000000 +0900 renamed from arch/arm/include/asm/hardirq.h +3 -1
-#if NR_IRQS > 256
+#if NR_IRQS > 512
+#define HARDIRQ_BITS ? 10
+#elif NR_IRQS > 256
Quoted 4 lines

?#define HARDIRQ_BITS ? 9
?#else
?#define HARDIRQ_BITS ? 8

Hi Russell,

Quoted 3 lines

Good to hear that you are back online. Do you want me to rework this patch somehow, or is it ready to be queued for upstream merge? I'm asking because I have a pile of patches that depend on this one.

I guess it's ok; with 10 bits we're at the maximum which the generic kernel supports (see linux/hardirq.h)

#3 lore raw

PATCH 1/1 ARM: Add support for 10 hardirq bits

Quoted 8 lines · Russell King - ARM Linux
Quoted 7 lines · Magnus Damm
Quoted 6 lines · Magnus Damm

From: Magnus Damm <[email protected]>

This patch adds support for 10 hardirq bits to
the ARM architecture. Needed by the SH-Mobile
ARM processor sh7372 that has more than 512 IRQs.

Quoted 6 lines
Quoted 3 lines
Quoted 3 lines

---

I guess it's ok; with 10 bits we're at the maximum which the generic kernel supports (see linux/hardirq.h)

Hi again Russell,

Will you pick up this one in your tree as-is, or would you like me to resubmit it somehow?

Perhaps you prefer that we take it with the other changes through the genesis-2.6 tree?

Sorry to bother you if this has already been sorted. I just noticed that the patch isn't part of the latest linux-next.

Thanks,

/ magnus

#4 lore raw

PATCH 1/1 ARM: Add support for 10 hardirq bits

Quoted 14 lines · Magnus Damm
Quoted 12 lines · Russell King - ARM Linux
Quoted 10 lines · Magnus Damm
Quoted 9 lines · Magnus Damm

From: Magnus Damm <[email protected]>

This patch adds support for 10 hardirq bits to
the ARM architecture. Needed by the SH-Mobile
ARM processor sh7372 that has more than 512 IRQs.

---

Quoted 8 lines
Quoted 2 lines

I guess it's ok; with 10 bits we're at the maximum which the generic kernel supports (see linux/hardirq.h)

Hi again Russell,

Will you pick up this one in your tree as-is, or would you like me to resubmit it somehow?

Russell,

I don't seem to find this patch in your -devel branch. I posted a same version of patch earlier, so I'd also like to see this get merged.

Magnus,

I guess you may please help submit this to rmk's patch tracking system?

#5 lore raw

PATCH 1/1 ARM: Add support for 10 hardirq bits

Quoted 9 lines · Eric Miao
Quoted 5 lines · Magnus Damm

Hi again Russell,

Will you pick up this one in your tree as-is, or would you like me to resubmit it somehow?

Russell,

Quoted 8 lines

I don't seem to find this patch in your -devel branch. I posted a same version of patch earlier, so I'd also like to see this get merged.

Magnus,

I guess you may please help submit this to rmk's patch tracking system?

Getting it into the patch system would be a big help, but since I've closed my tree down for this merge window already, it's missed the boat. (With Linus' new "random" behaviour wrt when things happen, I'm not planning on a second ARM kernel pull request - and the first was sent last night.)

This is probably the patch I was referring to in my notice of closure when I said:

| I know there was someone who was complaining a week or so ago that I
| hadn't applied their patch, which was only sent to the mailing list.
| Unfortunately, it being only on the mailing list and not in the patch
| system means I can't find it, nor the complaint about it not being
| applied.
|
| Whoever it was, sorry.

Especially as it's 4000 messages back in this mailbox!

#8 lore raw

PATCH 1/1 ARM: Add support for 10 hardirq bits

In reply to Eric Miao
Quoted 24 lines · Eric Miao
Quoted 14 lines · Magnus Damm
Quoted 12 lines · Russell King - ARM Linux
Quoted 10 lines · Magnus Damm
Quoted 9 lines · Magnus Damm

From: Magnus Damm <[email protected]>

This patch adds support for 10 hardirq bits to
the ARM architecture. Needed by the SH-Mobile
ARM processor sh7372 that has more than 512 IRQs.

---

Quoted 8 lines
Quoted 2 lines

I guess it's ok; with 10 bits we're at the maximum which the generic kernel supports (see linux/hardirq.h)

Hi again Russell,

Will you pick up this one in your tree as-is, or would you like me to resubmit it somehow?

Quoted 6 lines

Russell,

I don't seem to find this patch in your -devel branch. I posted a same version of patch earlier, so I'd also like to see this get merged.

Thanks, Eric!

Quoted 3 lines

Magnus,

I guess you may please help submit this to rmk's patch tracking system?

I've been trying to, but I guess I must have formatted it incorrectly since I don't hear anything back from the mail robot.

/ magnus

#6 lore raw

PATCH 1/1 ARM: Add support for 10 hardirq bits

In reply to Russell King - ARM Linux

Hi Russell,

Quoted 17 lines · Russell King - ARM Linux
Quoted 16 lines · Eric Miao
Quoted 5 lines · Magnus Damm

Hi again Russell,

Will you pick up this one in your tree as-is, or would you like me to resubmit it somehow?

Russell,

I don't seem to find this patch in your -devel branch. I posted a same version of patch earlier, so I'd also like to see this get merged.

Magnus,

Quoted 7 lines
Quoted 1 line

I guess you may please help submit this to rmk's patch tracking system?

Getting it into the patch system would be a big help, but since I've closed my tree down for this merge window already, it's missed the boat. ?(With Linus' new "random" behaviour wrt when things happen, I'm not planning on a second ARM kernel pull request - and the first was sent last night.)

It's there now:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6138/1

Anything I can do to make a second pull request happen? There are quite a few patches that depend on this one, so I posted it well in advace at March 10. The patch was kindly reviewed by you a bit later. And now I got an ack. Unfortunately I didn't proceed and submit it to the ARM-specific patch tracking system.

Quoted 11 lines

This is probably the patch I was referring to in my notice of closure when I said:

| I know there was someone who was complaining a week or so ago that I
| hadn't applied their patch, which was only sent to the mailing list.
| Unfortunately, it being only on the mailing list and not in the patch
| system means I can't find it, nor the complaint about it not being
| applied.
|
| Whoever it was, sorry.

Especially as it's 4000 messages back in this mailbox!

Sounds painful. =)

Thanks for your help!

/ magnus

#7 lore raw

PATCH 1/1 ARM: Add support for 10 hardirq bits

Quoted 10 lines
Quoted 10 lines

This is probably the patch I was referring to in my notice of closure when I said:

| I know there was someone who was complaining a week or so ago that I
| hadn't applied their patch, which was only sent to the mailing list.
| Unfortunately, it being only on the mailing list and not in the patch
| system means I can't find it, nor the complaint about it not being
| applied.
|
| Whoever it was, sorry.
Quoted 4 lines
Quoted 1 line

Especially as it's 4000 messages back in this mailbox!

Sounds painful. =)

I don't mean to push, and I fully understand that workload due to such a short -rc phase this time. Just wondering this can actually be made into the .35-rc phase?