Skip to contentSkip to conversation

x86, UV: Fix target_cpus() in x2apic_uv_x.c

PATCH In review Jack Steiner 1 participant 2 messages Mar 11, 2010 – Mar 12, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86, UV: Fix target_cpus() in x2apic_uv_x.c

target_cpu() should initially target all cpus, not just cpu 0. Otherwise systems with lots of disks can exhaust the interrupt vectors on cpu 0 if a large number of disks are discovered before the irq balancer is running.

Note: UV code only...

---
 arch/x86/kernel/apic/x2apic_uv_x.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/kernel/apic/x2apic_uv_x.c +1 -3
Index: linux/arch/x86/kernel/apic/x2apic_uv_x.c
===================================================================
@@ -120,11 +120,9 @@ EXPORT_SYMBOL_GPL(uv_possible_blades);
 unsigned long sn_rtc_cycles_per_second;
 EXPORT_SYMBOL(sn_rtc_cycles_per_second);
 
-/* Start with all IRQs pointing to boot CPU.  IRQ balancing will shift them. */
-
 static const struct cpumask *uv_target_cpus(void)
 {
-	return cpumask_of(0);
+	return cpu_online_mask;
 }
 
 static void uv_vector_allocation_domain(int cpu, struct cpumask *retmask)
#1 lore raw
Commit-ID:  8447b360a3897bdfb0677107564d1dd9ab6e63be
Gitweb:     http://git.kernel.org/tip/8447b360a3897bdfb0677107564d1dd9ab6e63be
Author:     Jack Steiner <[email protected]>
AuthorDate: Thu, 11 Mar 2010 12:43:29 -0600
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 12 Mar 2010 10:19:29 +0100

x86, UV: Fix target_cpus() in x2apic_uv_x.c

target_cpu() should initially target all cpus, not just cpu 0. Otherwise systems with lots of disks can exhaust the interrupt vectors on cpu 0 if a large number of disks are discovered before the irq balancer is running.

Note: UV code only...

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/apic/x2apic_uv_x.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
arch/x86/kernel/apic/x2apic_uv_x.c +1 -3
index 21db3cb..af0ca80 100644
@@ -114,11 +114,9 @@ EXPORT_SYMBOL_GPL(uv_possible_blades);
 unsigned long sn_rtc_cycles_per_second;
 EXPORT_SYMBOL(sn_rtc_cycles_per_second);
 
-/* Start with all IRQs pointing to boot CPU.  IRQ balancing will shift them. */
-
 static const struct cpumask *uv_target_cpus(void)
 {
-	return cpumask_of(0);
+	return cpu_online_mask;
 }
 
 static void uv_vector_allocation_domain(int cpu, struct cpumask *retmask)