Skip to contentSkip to conversation

vmwgfx: depends on FB

PATCH Applied [email protected] 2 participants 2 messages Mar 11, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/3 vmwgfx: depends on FB

From: Randy Dunlap <[email protected]>

vmwfgx uses framebuffer interfaces, so it should depend on FB. Otherwise it has these build errors (e.g., when CONFIG_FB=m):

drivers/built-in.o: In function `vmw_fb_close':
(.text+0x97713): undefined reference to unregister_framebuffer' drivers/built-in.o: In function vmw_fb_close':
(.text+0x97754): undefined reference to framebuffer_release' drivers/built-in.o: In function vmw_fb_init':
(.text+0x97e1c): undefined reference to framebuffer_alloc' drivers/built-in.o: In function vmw_fb_init':
(.text+0x9838d): undefined reference to register_framebuffer' drivers/built-in.o: In function vmw_fb_init':
(.text+0x9842a): undefined reference to `framebuffer_release'

---

 drivers/gpu/drm/vmwgfx/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/vmwgfx/Kconfig renamed from drivers/gpu/drm/vmwgfx/Kconfig~vmwgfx-depends-on-fb +1 -1
diff -puN drivers/gpu/drm/vmwgfx/Kconfig~vmwgfx-depends-on-fb drivers/gpu/drm/vmwgfx/Kconfig
@@ -1,6 +1,6 @@
 config DRM_VMWGFX
 	tristate "DRM driver for VMware Virtual GPU"
-	depends on DRM && PCI
+	depends on DRM && PCI && FB
 	select FB_DEFERRED_IO
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA

_

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

Acked-by on v1 2/3
#1 lore raw
Quoted 16 lines · On 11 mar 2010, at 22.01, [email protected] wrote:

From: Randy Dunlap <[email protected]>

vmwfgx uses framebuffer interfaces, so it should depend on FB. Otherwise it has these build errors (e.g., when CONFIG_FB=m):

drivers/built-in.o: In function `vmw_fb_close':
(.text+0x97713): undefined reference to unregister_framebuffer' drivers/built-in.o: In function vmw_fb_close':
(.text+0x97754): undefined reference to framebuffer_release' drivers/built-in.o: In function vmw_fb_init':
(.text+0x97e1c): undefined reference to framebuffer_alloc' drivers/built-in.o: In function vmw_fb_init':
(.text+0x9838d): undefined reference to register_framebuffer' drivers/built-in.o: In function vmw_fb_init':
(.text+0x9842a): undefined reference to `framebuffer_release'

Quoted 3 lines

Thanks and

Cheers Jakob.

Quoted 13 lines

---

drivers/gpu/drm/vmwgfx/Kconfig | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/gpu/drm/vmwgfx/Kconfig~vmwgfx-depends-on-fb drivers/gpu/drm/vmwgfx/Kconfig

drivers/gpu/drm/vmwgfx/Kconfig renamed from drivers/gpu/drm/vmwgfx/Kconfig~vmwgfx-depends-on-fb +0 -0
@@ -1,6 +1,6 @@

config DRM_VMWGFX
tristate "DRM driver for VMware Virtual GPU"

drivers/gpu/drm/vmwgfx/Kconfig renamed from drivers/gpu/drm/vmwgfx/Kconfig~vmwgfx-depends-on-fb +1 -1
-	depends on DRM && PCI
+	depends on DRM && PCI && FB
Quoted 5 lines

select FB_DEFERRED_IO
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
_

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel