markup_oops: fix perlcritic warnings

PATCH Applied [email protected] 1 participant 1 message Mar 11, 2010 Kbuild

lore

Share & tools

lore

[email protected]

author

2010-03-11 22:05 UTC #0 lore raw

PATCH 1/2 markup_oops: fix perlcritic warnings

From: Stephen Hemminger <[email protected]>

Turn on strict checking.
Use local file handles and 3 argument open.

Signed-off-by Stephen Hemminger <[email protected]>

Acked-by WANG Cong <[email protected]>

Cc Arjan van de Ven <[email protected]>

Cc Michal Marek <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

---

 scripts/markup_oops.pl |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

scripts/markup_oops.pl renamed from scripts/markup_oops.pl~markup_oops-fix-perlcritic-warnings +4 -2

diff -puN scripts/markup_oops.pl~markup_oops-fix-perlcritic-warnings scripts/markup_oops.pl
@@ -1,5 +1,7 @@
 #!/usr/bin/perl
 
+use strict;
+
 use File::Basename;
 use Math::BigInt;
 use Getopt::Long;

@@ -126,7 +128,7 @@ sub process_x86_regs
 		$clobber = "";
 	}
 
-	foreach $reg (keys(%regs)) {
+	foreach my $reg (keys(%regs)) {
 		my $clobberprime = reg_name($clobber);
 		my $lastwordprime = reg_name($lastword);
 		my $val = $regs{$reg};

@@ -263,7 +265,7 @@ while (<FILE>) {
 	}
 }
 
-close(FILE);
+close($file);
 
 if ($counter == 0) {
 	print "No matching code found \n";