Skip to contentSkip to conversation

drivers/scsi/bfa/bfad_im.c: eliminate useless code

PATCH In review [email protected] 1 participant 1 message Mar 11, 2010

Subsystems (2)
SCSI Brocade BFA FC SCSI driver
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 21/26 drivers/scsi/bfa/bfad_im.c: eliminate useless code

From: Julia Lawall <[email protected]>

The variable bfa_itnim is initialized twice to the same (side effect-free) expression. Drop one initialization.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)

// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@

x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>

Signed-off-by Julia Lawall <[email protected]>
Acked-by Jing Huang <[email protected]>
Cc James Bottomley <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/scsi/bfa/bfad_im.c |    1 -
 1 file changed, 1 deletion(-)
drivers/scsi/bfa/bfad_im.c renamed from drivers/scsi/bfa/bfad_im.c~drivers-scsi-bfa-bfad_imc-eliminate-useless-code +0 -1
diff -puN drivers/scsi/bfa/bfad_im.c~drivers-scsi-bfa-bfad_imc-eliminate-useless-code drivers/scsi/bfa/bfad_im.c
@@ -251,7 +251,6 @@ bfad_im_target_reset_send(struct bfad_s 
 	struct bfa_itnim_s *bfa_itnim;
 	bfa_status_t    rc = BFA_STATUS_OK;
 
-	bfa_itnim = bfa_fcs_itnim_get_halitn(&itnim->fcs_itnim);
 	tskim = bfa_tskim_alloc(&bfad->bfa, (struct bfad_tskim_s *) cmnd);
 	if (!tskim) {
 		BFA_DEV_PRINTF(bfad, BFA_ERR,

_