Skip to contentSkip to conversation

sched: remove some dead code

PATCH In review Dan Carpenter 2 participants 3 messages Mar 15, 2010 – Mar 16, 2010 Kernel janitors

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 sched: remove some dead code

This was left over from "7c9414385e sched: Remove USER_SCHED"

Signed-off-by Dan Carpenter <[email protected]>
kernel/user.c +0 -2
index 766467b..ec3b222 100644
@@ -178,8 +178,6 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid)
 
 	return up;
 
-	put_user_ns(new->user_ns);
-	kmem_cache_free(uid_cachep, new);
 out_unlock:
 	return NULL;
 }
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Dan Carpenter

This was left over from "7c9414385e sched: Remove USER_SCHED"

Quite surprising I missed that. Thanks for catching it.

Quoted 2 lines
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Dhaval Giani <[email protected]>
Quoted 10 lines
kernel/user.c +0 -2
index 766467b..ec3b222 100644
@@ -178,8 +178,6 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid)
 
        return up;
 
-       put_user_ns(new->user_ns);
-       kmem_cache_free(uid_cachep, new);
Quoted 4 lines

 out_unlock:
       return NULL;
 }

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw

[tip:sched/core] sched: Remove some dead code

In reply to Dan Carpenter
Commit-ID:  6427462bfa50f50dc6c088c07037264fcc73eca1
Gitweb:     http://git.kernel.org/tip/6427462bfa50f50dc6c088c07037264fcc73eca1
Author:     Dan Carpenter <[email protected]>
AuthorDate: Mon, 15 Mar 2010 11:21:48 +0300
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 16 Mar 2010 11:05:44 +0100

sched: Remove some dead code

This was left over from "7c9414385e sched: Remove USER_SCHED"

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Dhaval Giani <[email protected]>
Cc Kay Sievers <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

LKML-Reference: <20100315082148.GD18181@bicker>

Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/user.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/user.c +0 -2
index 766467b..ec3b222 100644
@@ -178,8 +178,6 @@ struct user_struct *alloc_uid(struct user_namespace *ns, uid_t uid)
 
 	return up;
 
-	put_user_ns(new->user_ns);
-	kmem_cache_free(uid_cachep, new);
 out_unlock:
 	return NULL;
 }