Skip to contentSkip to conversation

btrfs: checking for NULL instead of IS_ERR()

PATCH New Dan Carpenter 1 participant 1 message Mar 20, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 btrfs: checking for NULL instead of IS_ERR()

btrfs_get_extent() never returns NULL, only a valid pointer or ERR_PTR()

fs/btrfs/ioctl.c +1 -1
index 2845c6c..15f661d 100644
@@ -511,7 +511,7 @@ static int should_defrag_range(struct inode *inode, u64 start, u64 len,
 		em = btrfs_get_extent(inode, NULL, 0, start, len, 0);
 		unlock_extent(io_tree, start, start + len - 1, GFP_NOFS);
 
-		if (!em)
+		if (IS_ERR(em))
 			return 0;
 	}