Skip to contentSkip to conversation

kill the obsolete thread_group_cputime_free() and taskstats_tgid_init() helpers

PATCH In review Oleg Nesterov 1 participant 1 message Mar 21, 2010

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 2/3 kill the obsolete thread_group_cputime_free() and taskstats_tgid_init() helpers

Trivial, but a separate patch for paranoid reasons.

- Kill the empty thread_group_cputime_free() helper. It was needed to free the per-cpu data which we no longer have.

- Kill taskstats_tgid_init(), unneeded since "copy_signal() cleanup: use zalloc and remove initializations" a56704ef6b0c5796c9ff38cc78aa232dfb9644d7

---

 include/linux/sched.h          |    4 ----
 include/linux/taskstats_kern.h |    7 -------
 kernel/fork.c                  |    1 -
 3 files changed, 12 deletions(-)
include/linux/sched.h renamed from include/linux/sched.h~12_KILL_DEAD_HELPERS +0 -4
@@ -2396,10 +2396,6 @@ static inline void thread_group_cputime_
 	sig->cputimer.running = 0;
 }
 
-static inline void thread_group_cputime_free(struct signal_struct *sig)
-{
-}
-
 /*
  * Reevaluate whether the task has signals pending delivery.
  * Wake the task if so.
include/linux/taskstats_kern.h renamed from include/linux/taskstats_kern.h~12_KILL_DEAD_HELPERS +0 -7
@@ -14,11 +14,6 @@
 extern struct kmem_cache *taskstats_cache;
 extern struct mutex taskstats_exit_mutex;
 
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{
-	sig->stats = NULL;
-}
-
 static inline void taskstats_tgid_free(struct signal_struct *sig)
 {
 	if (sig->stats)
@@ -30,8 +25,6 @@ extern void taskstats_init_early(void);
 #else
 static inline void taskstats_exit(struct task_struct *tsk, int group_dead)
 {}
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{}
 static inline void taskstats_tgid_free(struct signal_struct *sig)
 {}
 static inline void taskstats_init_early(void)
kernel/fork.c renamed from kernel/fork.c~12_KILL_DEAD_HELPERS +0 -1
@@ -160,7 +160,6 @@ EXPORT_SYMBOL(free_task);
 
 static inline void free_signal_struct(struct signal_struct *sig)
 {
-	thread_group_cputime_free(sig);
 	kmem_cache_free(signal_cachep, sig);
 }