Skip to contentSkip to conversation

exit: move taskstats_tgid_free() from __exit_signal() to free_signal_struct()

PATCH In review Oleg Nesterov 1 participant 1 message Mar 21, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 3/3 exit: move taskstats_tgid_free() from __exit_signal() to free_signal_struct()

Move taskstats_tgid_free() from __exit_signal() to free_signal_struct().

This way signal->stats never points to nowhere and we can read ->stats lockless.

---

 kernel/exit.c |    1 -
 kernel/fork.c |    1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
kernel/exit.c renamed from kernel/exit.c~13_SIGNAL_STATS +0 -1
@@ -145,7 +145,6 @@ static void __exit_signal(struct task_st
 	clear_tsk_thread_flag(tsk,TIF_SIGPENDING);
 	if (group_dead) {
 		flush_sigqueue(&sig->shared_pending);
-		taskstats_tgid_free(sig);
 		tty_kref_put(tty);
 	}
 }
kernel/fork.c renamed from kernel/fork.c~13_SIGNAL_STATS +1 -0
@@ -160,6 +160,7 @@ EXPORT_SYMBOL(free_task);
 
 static inline void free_signal_struct(struct signal_struct *sig)
 {
+	taskstats_tgid_free(sig);
 	kmem_cache_free(signal_cachep, sig);
 }