Skip to contentSkip to conversation

pxa168fb: use resource_size()

PATCH In review Dan Carpenter 2 participants 2 messages Mar 22, 2010

Subsystems (2)
Kernel janitors Framebuffer layer
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 pxa168fb: use resource_size()

The size calculation is not correct. It should be end - start + 1. Use resource_size() to caculate it.

Signed-off-by Dan Carpenter <[email protected]>

---
This was found by a static checker and I don't have the hardware to test it. Please review carefully.

drivers/video/pxa168fb.c +1 -1
index 75285d3..c91a7f7 100644
@@ -668,7 +668,7 @@ static int __init pxa168fb_probe(struct platform_device *pdev)
 	/*
 	 * Map LCD controller registers.
 	 */
-	fbi->reg_base = ioremap_nocache(res->start, res->end - res->start);
+	fbi->reg_base = ioremap_nocache(res->start, resource_size(res));
 	if (fbi->reg_base = NULL) {
 		ret = -ENOMEM;
 		goto failed;