Skip to contentSkip to conversation

wimax: remove unneeded variable

PATCH In review Dan Carpenter 2 participants 2 messages Mar 24, 2010

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 wimax: remove unneeded variable

We never actually use "dev" so I removed it.

Signed-off-by Dan Carpenter <[email protected]>
net/wimax/op-reset.c +0 -2
index 4dc82a5..68bedf3 100644
@@ -110,7 +110,6 @@ int wimax_gnl_doit_reset(struct sk_buff *skb, struct genl_info *info)
 {
 	int result, ifindex;
 	struct wimax_dev *wimax_dev;
-	struct device *dev;
 
 	d_fnstart(3, NULL, "(skb %p info %p)\n", skb, info);
 	result = -ENODEV;

@@ -123,7 +122,6 @@ int wimax_gnl_doit_reset(struct sk_buff *skb, struct genl_info *info)
 	wimax_dev = wimax_dev_get_by_genl_info(info, ifindex);
 	if (wimax_dev = NULL)
 		goto error_no_wimax_dev;
-	dev = wimax_dev_to_dev(wimax_dev);
 	/* Execute the operation and send the result back to user space */
 	result = wimax_reset(wimax_dev);
 	dev_put(wimax_dev->net_dev);
net/wimax/op-state-get.c +0 -2
index 11ad335..aff8776 100644
@@ -53,7 +53,6 @@ int wimax_gnl_doit_state_get(struct sk_buff *skb, struct genl_info *info)
 {
 	int result, ifindex;
 	struct wimax_dev *wimax_dev;
-	struct device *dev;
 
 	d_fnstart(3, NULL, "(skb %p info %p)\n", skb, info);
 	result = -ENODEV;

@@ -66,7 +65,6 @@ int wimax_gnl_doit_state_get(struct sk_buff *skb, struct genl_info *info)
 	wimax_dev = wimax_dev_get_by_genl_info(info, ifindex);
 	if (wimax_dev = NULL)
 		goto error_no_wimax_dev;
-	dev = wimax_dev_to_dev(wimax_dev);
 	/* Execute the operation and send the result back to user space */
 	result = wimax_state_get(wimax_dev);
 	dev_put(wimax_dev->net_dev);
maintainer
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Wed, 24 Mar 2010 14:56:03 +0300

Quoted 3 lines

We never actually use "dev" so I removed it.

Signed-off-by Dan Carpenter <[email protected]>

I think the intention was to pass it into to these stupid function call tracing debugging macros the WIMAX stuff has. It's passing NULL currently.

Anyways, I've applied this, thanks.

But seriously, why is every developer of some new subsystem or driver inclined to add such ugly debugging infrastructure? It's seemingly the first thing they do before writing any code.

I'd very much like to see a patch that removes all of this junk and "rm -f include/linux/wimax/debug.h"