backing-dev: Handle class_create() failure

PATCH In review Anton Blanchard 2 participants 2 messages Apr 2, 2010

Subsystems (2)

Memory management MM misc

lore

Share & tools

lore

Anton Blanchard

author

2010-04-02 07:32 UTC #0 lore raw

PATCH 1/1 backing-dev: Handle class_create() failure

I hit this when we had a bug in IDR for a few days. Basically sysfs would fail to create new inodes since it uses an IDR and therefore class_create would fail.

While we are unlikely to see this fail we may as well handle it instead of oopsing.

Signed-off-by Anton Blanchard <[email protected]>

---

mm/backing-dev.c +3 -0

index 0e8ca03..f13e067 100644
@@ -227,6 +227,9 @@ static struct device_attribute bdi_dev_attrs[] = {
 static __init int bdi_class_init(void)
 {
 	bdi_class = class_create(THIS_MODULE, "bdi");
+	if (IS_ERR(bdi_class))
+		return PTR_ERR(bdi_class);
+
 	bdi_class->dev_attrs = bdi_dev_attrs;
 	bdi_debug_init();
 	return 0;

Jens Axboe

2010-04-02 07:46 UTC #1 lore raw

Quoted 7 lines · Anton Blanchard

I hit this when we had a bug in IDR for a few days. Basically sysfs would fail to create new inodes since it uses an IDR and therefore class_create would fail.
While we are unlikely to see this fail we may as well handle it instead of oopsing.

Thanks Anton, applied.

Signature · 1 line

Jens Axboe