cx231xx: improve error handling

PATCH New Dan Carpenter 1 participant 1 message Apr 2, 2010 Media (V4L/DVB)

lore

Share & tools

lore

Dan Carpenter

author

2010-04-02 11:36 UTC #0 lore raw

PATCH 1/1 cx231xx: improve error handling

Return -EINVAL if we don't find the control id.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/video/cx231xx/cx231xx-video.c +4 -1

index d4f546f..5a74ef8 100644
@@ -1901,9 +1901,12 @@ static int radio_queryctrl(struct file *file, void *priv,
 	if (c->id < V4L2_CID_BASE || c->id >= V4L2_CID_LASTP1)
 		return -EINVAL;
 	if (c->id == V4L2_CID_AUDIO_MUTE) {
-		for (i = 0; i < CX231XX_CTLS; i++)
+		for (i = 0; i < CX231XX_CTLS; i++) {
 			if (cx231xx_ctls[i].v.id == c->id)
 				break;
+		}
+		if (i == CX231XX_CTLS)
+			return -EINVAL;
 		*c = cx231xx_ctls[i].v;
 	} else
 		*c = no_ctl;