Skip to contentSkip to conversation

xfstests: don't use -s option to repquota

PATCH In review Christoph Hellwig 3 participants 3 messages Apr 5, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: don't use -s option to repquota

The -s option to repquota used to be a no-op, but actually changes output to different units in quota tools 4.0. Remove it from the repquota invocation in test 219.

219 +1 -1
Index: xfstests-dev/219
===================================================================
@@ -85,7 +85,7 @@ test_accounting()
 		$here/src/lstat64 $file | head -3 | filter_scratch
 	done
 
-	repquota -$type -s -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
+	repquota -$type -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
 	awk '/^#/ { if (seen[$1]) next; seen[$1]++; } { print; }'
 }
 

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Christoph Hellwig

The -s option to repquota used to be a no-op, but actually changes output to different units in quota tools 4.0. Remove it from the repquota invocation in test 219.

Thanks, Ted was hitting this too.

Quoted 14 lines

Index: xfstests-dev/219
===================================================================

219 +1 -1
@@ -85,7 +85,7 @@ test_accounting()
 		$here/src/lstat64 $file | head -3 | filter_scratch
 	done
 
-	repquota -$type -s -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
+	repquota -$type -n $SCRATCH_MNT  | grep -v "^#0" | filter_scratch |
 	awk '/^#/ { if (seen[$1]) next; seen[$1]++; } { print; }'
 }
 
Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 10 lines · Eric Sandeen
Quoted 5 lines · Christoph Hellwig

The -s option to repquota used to be a no-op, but actually changes output to different units in quota tools 4.0. Remove it from the repquota invocation in test 219.

Thanks, Ted was hitting this too.

Thanks, I had submitting the patch on my todo list, and you just saved me the effort of sending it. :-)

I already had this change in my tree, and it works fine for me.

- Ted

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs