nouveau: fix memory leak
Subsystems (4)
PATCH 1/1 nouveau: fix memory leak
In the original code there was a typo and we called kfree(pgraph->ctxprog) two times instead of kfree(pgraph->ctxvals);
Also it's OK to pass NULL variables to kfree(). checkpatch.pl complains about this so I removed the checks.
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/nouveau/nouveau_grctx.c +4 -8
@@ -134,15 +134,11 @@ nouveau_grctx_fini(struct drm_device *dev)struct drm_nouveau_private *dev_priv = dev->dev_private;struct nouveau_pgraph_engine *pgraph = &dev_priv->engine.graph; -if (pgraph->ctxprog) { -kfree (pgraph->ctxprog); - pgraph->ctxprog =NULL ; - } +kfree (pgraph->ctxprog); + pgraph->ctxprog =NULL ; -if (pgraph->ctxvals) { -kfree (pgraph->ctxprog); - pgraph->ctxvals =NULL ; - } +kfree (pgraph->ctxvals); + pgraph->ctxvals =NULL ; }void
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--