video: comparing unsigned with negative 0

PATCH New Dan Carpenter 1 participant 1 message Apr 7, 2010

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-04-07 09:41 UTC #0 lore raw

PATCH 1/1 video: comparing unsigned with negative 0

soc_mbus_bytes_per_line() returns -EINVAL on error but we store it in an unsigned int so the test for less than zero doesn't work. I think it always returns "small" positive values so we can just cast it to int here.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/video/sh_mobile_ceu_camera.c +1 -1

index 6e16b39..1ad980f 100644
@@ -1633,7 +1633,7 @@ static int sh_mobile_ceu_try_fmt(struct soc_camera_device *icd,
 	height = pix->height;
 
 	pix->bytesperline = soc_mbus_bytes_per_line(width, xlate->host_fmt);
-	if (pix->bytesperline < 0)
+	if ((int)pix->bytesperline < 0)
 		return pix->bytesperline;
 	pix->sizeimage = height * pix->bytesperline;