Skip to contentSkip to conversation

hwmon: (it87) Don't arbitrarily enable

PATCH New Jean Delvare 1 participant 1 message Apr 9, 2010

Subsystems (2)
Hardware monitoring IT87 hardware monitoring driver
lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/2 hwmon: (it87) Don't arbitrarily enable

Temperature channels can be used in 2 different modes (thermistor and thermal diode) and we don't know which one, if any, is correct for every given board. So don't arbitrarily choose one. Instead, leave the temperature channels untouched. They can be configured from user-space if needed anyway.

Signed-off-by Jean Delvare <[email protected]>
---
 drivers/hwmon/it87.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/hwmon/it87.c +1 -9
@@ -545,6 +545,7 @@ static ssize_t set_sensor(struct device
 
 	mutex_lock(&data->update_lock);
 
+	data->sensor = it87_read_value(data, IT87_REG_TEMP_ENABLE);
 	data->sensor &= ~(1 << nr);
 	data->sensor &= ~(8 << nr);
 	if (val = 2) {	/* backwards compatibility */

@@ -1841,15 +1842,6 @@ static void __devinit it87_init_device(s
 			it87_write_value(data, IT87_REG_TEMP_HIGH(i), 127);
 	}
 
-	/* Check if temperature channels are reset manually or by some reason */
-	tmp = it87_read_value(data, IT87_REG_TEMP_ENABLE);
-	if ((tmp & 0x3f) = 0) {
-		/* Temp1,Temp3=thermistor; Temp2=thermal diode */
-		tmp = (tmp & 0xc0) | 0x2a;
-		it87_write_value(data, IT87_REG_TEMP_ENABLE, tmp);
-	}
-	data->sensor = tmp;
-
 	/* Check if voltage monitors are reset manually or by some reason */
 	tmp = it87_read_value(data, IT87_REG_VIN_ENABLE);
 	if ((tmp & 0xff) = 0) {
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors