Skip to contentSkip to conversation

VGA Bios allow 1920x1080

PATCH In review Øyvind Sæther 3 participants 4 messages Apr 13, 2010 – Apr 18, 2010 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 VGA Bios allow 1920x1080

The patch lets me run 1920x1080 resolution, some displays are only that and not 1920x1200 these days. Gentoos ebuild doesn't seem to make the vgabios and only uses /pc-bios/vgabios.bin, making kvm/vgabios and replace vgabios.bin with the VGABIOS-lgpl-latest.bin it makes works (for me).

vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200 renamed from vbetables-gen.c 2010-04-13 06:04:09.874359455 +0200 +9 -6
@@ -73,12 +73,15 @@
 { 1680, 1050, 16                     , 0x184},
 { 1680, 1050, 24                     , 0x185},
 { 1680, 1050, 32                     , 0x186},
-{ 1920, 1200, 16                     , 0x187},
-{ 1920, 1200, 24                     , 0x188},
-{ 1920, 1200, 32                     , 0x189},
-{ 2560, 1600, 16                     , 0x18a},
-{ 2560, 1600, 24                     , 0x18b},
-{ 2560, 1600, 32                     , 0x18c},
+{ 1920, 1080, 16                     , 0x187},
+{ 1920, 1080, 24                     , 0x188},
+{ 1920, 1080, 32                     , 0x189},
+{ 1920, 1200, 16                     , 0x18a},
+{ 1920, 1200, 24                     , 0x18b},
+{ 1920, 1200, 32                     , 0x18c},
+{ 2560, 1600, 16                     , 0x18d},
+{ 2560, 1600, 24                     , 0x18e},
+{ 2560, 1600, 32                     , 0x18f},
 { 0, },
 };
#1 lore raw
Quoted 7 lines · Øyvind Sæther

The patch lets me run 1920x1080 resolution, some displays are only that and not 1920x1200 these days. Gentoos ebuild doesn't seem to make the vgabios and only uses /pc-bios/vgabios.bin, making kvm/vgabios and replace vgabios.bin with the VGABIOS-lgpl-latest.bin it makes works (for me).

Missing signoff.

Quoted 14 lines
vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200 renamed from vbetables-gen.c 2010-04-13 06:04:09.874359455 +0200 +2 -6
@@ -73,12 +73,15 @@
  { 1680, 1050, 16                     , 0x184},
  { 1680, 1050, 24                     , 0x185},
  { 1680, 1050, 32                     , 0x186},
-{ 1920, 1200, 16                     , 0x187},
-{ 1920, 1200, 24                     , 0x188},
-{ 1920, 1200, 32                     , 0x189},
-{ 2560, 1600, 16                     , 0x18a},
-{ 2560, 1600, 24                     , 0x18b},
-{ 2560, 1600, 32                     , 0x18c},
+{ 1920, 1080, 16                     , 0x187},
+{ 1920, 1080, 24                     , 0x188},

vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200 line 87

Quoted 10 lines
vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200 renamed from vbetables-gen.c 2010-04-13 06:04:09.874359455 +0200 +7 -0
+{ 1920, 1080, 32                     , 0x189},
+{ 1920, 1200, 16                     , 0x18a},
+{ 1920, 1200, 24                     , 0x18b},
+{ 1920, 1200, 32                     , 0x18c},
+{ 2560, 1600, 16                     , 0x18d},
+{ 2560, 1600, 24                     , 0x18e},
+{ 2560, 1600, 32                     , 0x18f},
  { 0, },
  };
 

Please don't modify the existing mode numbers.

Signature · 1 line
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
#2 lore raw
Quoted 6 lines
Quoted 5 lines

The patch lets me run 1920x1080 resolution, some displays are only that and not 1920x1200 these days. Gentoos ebuild doesn't seem to make the vgabios and only uses /pc-bios/vgabios.bin, making kvm/vgabios and replace vgabios.bin with the VGABIOS-lgpl-latest.bin it makes works (for me).

Missing signoff.

I have never submitted much to any big project, so sorry, and am not sure what you mean by "Missing signoff". How do I .. signoff?

Quoted 24 lines
Quoted 24 lines
vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200 renamed from vbetables-gen.c 2010-04-13 06:04:09.874359455 +0200 +9 -6
@@ -73,12 +73,15 @@
 
  { 1680, 1050, 16                     , 0x184},
  { 1680, 1050, 24                     , 0x185},
  { 1680, 1050, 32                     , 0x186},
 
-{ 1920, 1200, 16                     , 0x187},
-{ 1920, 1200, 24                     , 0x188},
-{ 1920, 1200, 32                     , 0x189},
-{ 2560, 1600, 16                     , 0x18a},
-{ 2560, 1600, 24                     , 0x18b},
-{ 2560, 1600, 32                     , 0x18c},
+{ 1920, 1080, 16                     , 0x187},
+{ 1920, 1080, 24                     , 0x188},
+{ 1920, 1080, 32                     , 0x189},
+{ 1920, 1200, 16                     , 0x18a},
+{ 1920, 1200, 24                     , 0x18b},
+{ 1920, 1200, 32                     , 0x18c},
+{ 2560, 1600, 16                     , 0x18d},
+{ 2560, 1600, 24                     , 0x18e},
+{ 2560, 1600, 32                     , 0x18f},
 
Quoted 4 lines
Quoted 2 lines
  { 0, },
  };

Please don't modify the existing mode numbers.

So sorry about that, it somehow just looked cleaner to get them listed in sequense. Adding new modes to the end of what was there works too.

vbetables-gen.c.new3 2010-04-17 23:05:39.722313167 +0200 renamed from vbetables-gen.c.original 2010-04-13 05:51:09.134232495 +0200 +3 -0
@@ -79,6 +79,9 @@
 { 2560, 1600, 16                     , 0x18a},
 { 2560, 1600, 24                     , 0x18b},
 { 2560, 1600, 32                     , 0x18c},
+{ 1920, 1080, 16                     , 0x18d},
+{ 1920, 1080, 24                     , 0x18e},
+{ 1920, 1080, 32                     , 0x18f},
 { 0, },
 };
 
#3 lore raw

2010/4/18 Øyvind Sæther <[email protected]>:

Quoted 9 lines
Quoted 6 lines
Quoted 5 lines

The patch lets me run 1920x1080 resolution, some displays are only that and not 1920x1200 these days. Gentoos ebuild doesn't seem to make the vgabios and only uses /pc-bios/vgabios.bin, making kvm/vgabios and replace vgabios.bin with the VGABIOS-lgpl-latest.bin it makes works (for me).

Missing signoff.

I have never submitted much to any big project, so sorry, and am not sure what you mean by "Missing signoff". How do I .. signoff?

For Your Information:

http://git.kernel.org/?p=virt/kvm/kvm.git;a=blob;f=Documentation/SubmittingPatches;h=72651f788f4e3536149ef5e7ddfbed96a8f14d2f;hb=HEAD

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
vbetables-gen.c.new 2010-04-13 06:04:03.955480621 +0200 renamed from vbetables-gen.c     2010-04-13 06:04:09.874359455 +0200 +0 -0
@@ -73,12 +73,15 @@
 
   { 1680, 1050, 16                     , 0x184},

...