Skip to contentSkip to conversation

KVM: fix emulator_task_switch() return value.

PATCH New Gleb Natapov 1 participant 1 message Apr 15, 2010

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Gleb Natapov

author
#0 lore raw

PATCH 1/1 KVM: fix emulator_task_switch() return value.

emulator_task_switch() should return -1 for failure and 0 for success to the caller, just like x86_emulate_insn() does.

Signed-off-by Gleb Natapov <[email protected]>
arch/x86/kvm/emulate.c +1 -1
index 083b269..b836900 100644
@@ -2437,7 +2437,7 @@ int emulator_task_switch(struct x86_emulate_ctxt *ctxt,
 		kvm_rip_write(ctxt->vcpu, c->eip);
 	}
 
-	return rc;
+	return (rc == X86EMUL_UNHANDLEABLE) ? -1 : 0;
 }
 
 static void string_addr_inc(struct x86_emulate_ctxt *ctxt, unsigned long base,
arch/x86/kvm/x86.c +4 -3
index 11aef42..aa884f9 100644
@@ -4811,10 +4811,11 @@ int kvm_task_switch(struct kvm_vcpu *vcpu, u16 tss_selector, int reason)
 	ret = emulator_task_switch(&vcpu->arch.emulate_ctxt, &emulate_ops,
 				   tss_selector, reason);
 
-	if (ret == X86EMUL_CONTINUE)
-		kvm_x86_ops->set_rflags(vcpu, vcpu->arch.emulate_ctxt.eflags);
+	if (ret)
+		return EMULATE_FAIL;
 
-	return (ret != X86EMUL_CONTINUE);
+	kvm_x86_ops->set_rflags(vcpu, vcpu->arch.emulate_ctxt.eflags);
+	return EMULATE_DONE;
 }
 EXPORT_SYMBOL_GPL(kvm_task_switch);

--
Gleb.